Date: Sun, 16 Sep 2018 22:08:12 +0200 From: Rainer Hurling <rhurlin@gwdg.de> To: Marco Beishuizen <mbeis@xs4all.nl> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: pkg-plist and stage directory for new port Message-ID: <c65ed322-c092-9dc5-7692-f8a56a4a630e@gwdg.de> In-Reply-To: <alpine.BSF.2.21.9999.1809141728230.2970@yokozuna.lan> References: <alpine.BSF.2.21.9999.1809141634380.2970@yokozuna.lan> <_rTKdZNUI1ulLacZQn9a0ZgOA6w8IlUrUkgb96rER7AyW5LPetvQZQQWYDjRWNFRxZrT1qkzM-v76wX-7q4yOJ4cAu6G3EcLkSYqHCBM9kQ=@protonmail.ch> <alpine.BSF.2.21.9999.1809141728230.2970@yokozuna.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Marco,
just a few comments about your port stub.
Am 14.09.18 um 17:31 schrieb Marco Beishuizen:
> On Fri, 14 Sep 2018, the wise Lorenzo Salvadore via freebsd-ports wrote:
>
>> Show us your makefile please.
>
> The Makefile I have so far:
>
> PORTNAME= pgadmin4
> PORTVERSION= 3.3
> CATEGORIES= databases
> MASTER_SITES= PGSQL/pgadmin/pgadmin4/v${PORTVERSION}/source/
I would insert the next line, because it is common for Postgres ports
for years now, to hold the distfiles under distfiles/postgresql/
DIST_SUBDIR= postgresql
I think, the following line is not necessary, the port fetches and build
fine without it:
> DISTNAME= pgadmin4-${PORTVERSION}
>
> MAINTAINER= mbeis@xs4all.nl
> COMMENT= PostgreSQL Administration Tool
>
> LICENSE= PostgreSQL
>
> BUILD_DEPENDS sphinx-build:textproc/py-sphinx
> USES= pgsql python qmake:outsource qt:5
> USE_QT= core gui network widgets
> QMAKE_SOURCE_PATH= ${WRKSRC}/runtime
>
> .include <bsd.port.mk>
>
>> When I created my first port, I remember I had some difficulty to
>> understand staging: imho it needs to be explained better in the
>> documentation. Are you aware of the variable ${STAGEDIR}? You probably
>> need to add to your makefile some lines similar to the followings:
>>
>> do-install:
>> ${INSTALL_PROGRAM} ${WRKSRC}/??/pgAdmin4 ${STAGEDIR}${PREFIX}/bin
>
> Quite possible that it's something like this. I'll dig into it.
Most of the needed stuff seems to be under ${WORKSRC}/runtime and
${WORKSRC}/web.
HTH a little bit.
Greetings,
Rainer
>
> Thanks,
>
> Marco
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c65ed322-c092-9dc5-7692-f8a56a4a630e>