Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 May 2013 09:51:27 +0000 (UTC)
From:      Dag-Erling Smørgrav <des@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r251057 - user/des/zfs-backup
Message-ID:  <201305280951.r4S9pRxv012796@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: des
Date: Tue May 28 09:51:27 2013
New Revision: 251057
URL: http://svnweb.freebsd.org/changeset/base/251057

Log:
  A missing $ caused the script to look in the wrong place when trying
  to determine whether this was a first or subsequent run - but only
  when backing up a non-root dataset.
  
  Also, use [ -t 0 ] instead of tty(1).

Modified:
  user/des/zfs-backup/zfs-backup.sh

Modified: user/des/zfs-backup/zfs-backup.sh
==============================================================================
--- user/des/zfs-backup/zfs-backup.sh	Tue May 28 09:33:46 2013	(r251056)
+++ user/des/zfs-backup/zfs-backup.sh	Tue May 28 09:51:27 2013	(r251057)
@@ -86,13 +86,13 @@ fi
 if [ "${fqsrc#$fqdst/}" != "$fqsrc" -o "${fqdst#$fqsrc/}" != "$fqdst" ] ; then
 	error "source and destination must be non-overlapping datasets"
 fi
-case src in
+case "$src" in
 */*)
 	sub="/${src#*/}"
 	;;
 esac
 
-if tty >/dev/null ; then
+if [ -t 0 ] ; then
 	verbose="-v"
 fi
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305280951.r4S9pRxv012796>