Date: Sun, 6 Jan 2002 17:45:53 -0500 (EST) From: Mike Silbersack <silby@silby.com> To: Bruce Evans <bde@zeta.org.au> Cc: Mike Silbersack <silby@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/kern uipc_socket2.c Message-ID: <Pine.BSF.4.30.0201061726320.87891-100000@niwun.pair.com> In-Reply-To: <20020106222133.H3630-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 6 Jan 2002, Bruce Evans wrote: > Er, this was already fixed (mostly better) in rev.1.19. Quad arithmetic > is used to inhibit overflow. Overflow can only occur for multi-gigabyte > buffer sizes which can only even occur in theory on machines with > u_long larger than 32 bits (since sb_max has type u_long). But sb_max's > larger than UINT_MAX cause bugs in sbreserve anyway, since the wrong > min() function is used for limiting sb->sb_max to sb_max. > > Bruce Urk, I assumed quad meant 8*4 bits. I'll revert the change. As for the (?)min functions... why are they defined in libkern.h, rather than types.h. Isn't min a compiler builtin? Thanks, Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.30.0201061726320.87891-100000>