Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 03 Dec 2025 23:19:59 +0000
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: ee18f8be2165 - main - tcp: don't set flowid in tcp_input()
Message-ID:  <6930c59f.3e606.697bc870@gitrepo.freebsd.org>
index | next in thread | raw e-mail 

The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/src/commit/?id=ee18f8be21655c2d98c1c1bd4e081c366fa91c9a

commit ee18f8be21655c2d98c1c1bd4e081c366fa91c9a
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2025-12-03 23:15:45 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2025-12-03 23:19:44 +0000

    tcp: don't set flowid in tcp_input()
    
    With dd0e6bb996dc setting it always on connect(2) and syncache always
    picking up the flowid from the incoming packet, any ESTABLISHED connection
    shall have the flowid already set.
    
    Reviewed by:            tuexen, gallatin
    Differential Revision:  https://reviews.freebsd.org/D53886
---
 sys/netinet/tcp_input.c | 31 -------------------------------
 1 file changed, 31 deletions(-)

diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c
index 9014dd690764..0036a07384ae 100644
--- a/sys/netinet/tcp_input.c
+++ b/sys/netinet/tcp_input.c
@@ -923,37 +923,6 @@ findpcb:
 	}
 	INP_LOCK_ASSERT(inp);
 
-	if ((inp->inp_flowtype == M_HASHTYPE_NONE) &&
-	    !SOLISTENING(inp->inp_socket)) {
-		if (M_HASHTYPE_GET(m) != M_HASHTYPE_NONE) {
-			inp->inp_flowid = m->m_pkthdr.flowid;
-			inp->inp_flowtype = M_HASHTYPE_GET(m);
-#ifdef	RSS
-		} else {
-			  /* assign flowid by software RSS hash */
-#ifdef INET6
-			  if (isipv6) {
-				rss_proto_software_hash_v6(&inp->in6p_faddr,
-							   &inp->in6p_laddr,
-							   inp->inp_fport,
-							   inp->inp_lport,
-							   IPPROTO_TCP,
-							   &inp->inp_flowid,
-							   &inp->inp_flowtype);
-			  } else
-#endif	/* INET6 */
-			  {
-				rss_proto_software_hash_v4(inp->inp_faddr,
-							   inp->inp_laddr,
-							   inp->inp_fport,
-							   inp->inp_lport,
-							   IPPROTO_TCP,
-							   &inp->inp_flowid,
-							   &inp->inp_flowtype);
-			  }
-#endif	/* RSS */
-		}
-	}
 #if defined(IPSEC) || defined(IPSEC_SUPPORT)
 #ifdef INET6
 	if (isipv6 && IPSEC_ENABLED(ipv6) &&
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6930c59f.3e606.697bc870>