Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Jul 2026 13:11:43 +0000
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 2f1ec7d159cb - main - ktimer: Check for errors from realtimer_gettime()
Message-ID:  <6a5a2a0f.40128.20257f10@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=2f1ec7d159cbe56d40e7b6d7fc4188c9079e1783

commit 2f1ec7d159cbe56d40e7b6d7fc4188c9079e1783
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2026-07-17 13:08:33 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2026-07-17 13:08:33 +0000

    ktimer: Check for errors from realtimer_gettime()
    
    clock_gettime(CLOCK_TAI) can fail, leaving *ovalue uninitialized.
    
    Reported by:    Hazley Samsudin of GovTech CSG
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D58225
---
 sys/kern/kern_time.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/sys/kern/kern_time.c b/sys/kern/kern_time.c
index 82c2f7367ab2..b9daad17c639 100644
--- a/sys/kern/kern_time.c
+++ b/sys/kern/kern_time.c
@@ -1634,8 +1634,11 @@ realtimer_settime(struct itimer *it, int flags, struct itimerspec *value,
 		timespecclear(&val.it_interval);
 	}
 
-	if (ovalue != NULL)
-		realtimer_gettime(it, ovalue);
+	if (ovalue != NULL) {
+		error = realtimer_gettime(it, ovalue);
+		if (error != 0)
+			return (error);
+	}
 
 	it->it_time = val;
 	if (timespecisset(&val.it_value)) {


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a5a2a0f.40128.20257f10>