Date: Tue, 24 Sep 2002 13:01:54 +0200 (CEST) From: Stefan Farfeleder <e0026813@stud3.tuwien.ac.at> To: FreeBSD-gnats-submit@FreeBSD.org Cc: mike@FreeBSD.org Subject: standards/43326: [PATCH?] <nl_types.h> needs previous inclusion of <sys/_types.h> Message-ID: <20020924110154.264562C@frog.fafoe>
next in thread | raw e-mail | index | archive | help
>Number: 43326
>Category: standards
>Synopsis: [PATCH?] <nl_types.h> needs previous inclusion of <sys/_types.h>
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-standards
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Sep 24 04:10:05 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Stefan Farfeleder
>Release: FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD frog.fafoe 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Mon Sep 23 18:09:18 CEST 2002 freebsd@frog.fafoe:/freebsd/current/obj/freebsd/current/src/sys/FROG i386
>Description:
This commit:
mike 2002/09/17 22:51:23 PDT
Modified files:
include nl_types.h
sys/sys _types.h
Log:
Move definition of nl_item type to <sys/_types.h>, so that it can be
shared.
Revision Changes Path
1.9 +5 -1 src/include/nl_types.h
1.8 +1 -0 src/sys/sys/_types.h
made it necessary to include sys/_types.h before including nl_types.h
since the new typedef of __nl_item was put into the former header.
>How-To-Repeat:
ports/x11-wm/blackbox doens't build anymore on -current because of this.
According to catopen(3), the following test program should compile:
#include <nl_types.h>
int
main(void)
{
catopen("", 0);
return 0;
}
>Fix:
If nl_types.h would include sys/_types.h itself instead of sys/cdefs.h,
the old behaviour would be restored. I don't know whether this would introduce
any namespace pollution.
--- nl_types.h.orig Mon Sep 23 19:35:23 2002
+++ nl_types.h Tue Sep 24 12:03:27 2002
@@ -34,7 +34,7 @@
#ifndef _NL_TYPES_H_
#define _NL_TYPES_H_
-#include <sys/cdefs.h>
+#include <sys/_types.h>
#define NL_SETD 0
#define NL_CAT_LOCALE 1
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-standards" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020924110154.264562C>