Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Dec 2018 14:49:41 -0500
From:      Shawn Webb <shawn.webb@hardenedbsd.org>
To:        Rebecca Cran <bcran@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r342283 - in head: release/amd64 release/arm64 release/i386 release/tools share/man/man8 tools/boot tools/tools/nanobsd/embedded usr.sbin/bsdinstall/partedit usr.sbin/bsdinstall/scripts
Message-ID:  <20181220194941.wikdor2wnsr56g4n@mutt-hbsd>
In-Reply-To: <201812201939.wBKJdbhB015092@repo.freebsd.org>
References:  <201812201939.wBKJdbhB015092@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--vxzaspxr2v4rrzcc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 20, 2018 at 07:39:37PM +0000, Rebecca Cran wrote:
> Author: bcran
> Date: Thu Dec 20 19:39:37 2018
> New Revision: 342283
> URL: https://svnweb.freebsd.org/changeset/base/342283
>=20
> Log:
>   Rework UEFI ESP generation
>  =20
>   Currently, the installer uses pre-created 800KB FAT12 filesystems that
>   it dd's onto the ESP partition.
>   This changeset improves that by having the installer generate a FAT32
>   filesystem directly onto the ESP using newfs_msdos and then copying
>   loader.efi into /EFI/freebsd.
>   For live installs it then runs efibootmgr to add a FreeBSD boot entry
>   in the BIOS.
>  =20
>   Sponsored by:	Netflix
>   Differential Revision:	https://reviews.freebsd.org/D17947
>=20
> Modified:
>   head/release/amd64/make-memstick.sh
>   head/release/amd64/mkisoimages.sh
>   head/release/arm64/make-memstick.sh
>   head/release/i386/make-memstick.sh
>   head/release/tools/vmimage.subr
>   head/share/man/man8/uefi.8
>   head/tools/boot/install-boot.sh
>   head/tools/boot/rootgen.sh
>   head/tools/tools/nanobsd/embedded/common
>   head/usr.sbin/bsdinstall/partedit/gpart_ops.c
>   head/usr.sbin/bsdinstall/partedit/partedit_arm64.c
>   head/usr.sbin/bsdinstall/partedit/partedit_x86.c
>   head/usr.sbin/bsdinstall/scripts/bootconfig
>   head/usr.sbin/bsdinstall/scripts/zfsboot
>=20
> Modified: head/release/amd64/make-memstick.sh
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/release/amd64/make-memstick.sh	Thu Dec 20 19:27:46 2018	(r342282)
> +++ head/release/amd64/make-memstick.sh	Thu Dec 20 19:39:37 2018	(r342283)
> @@ -12,6 +12,9 @@
> =20
>  set -e
> =20
> +scriptdir=3D$(dirname $(realpath $0))
> +. ${scriptdir}/../../tools/boot/install-boot.sh
> +
>  PATH=3D/bin:/usr/bin:/sbin:/usr/sbin
>  export PATH
> =20
> @@ -36,11 +39,16 @@ makefs -B little -o label=3DFreeBSD_Install -o versio=
n=3D2
>  rm ${1}/etc/fstab
>  rm ${1}/etc/rc.conf.local
> =20
> +# Make an ESP in a file.
> +espfilename=3D$(mktemp /tmp/efiboot.XXXXXX)
> +make_esp_file ${espfilename} ${fat32min} ${1}/boot/loader.efi

Hey Rebecca,

Are there any other bits of the build process that touch files outside
of ${MAKEOBJDIRPREFIX}?

Thanks,

--=20
Shawn Webb
Cofounder and Security Engineer
HardenedBSD

Tor-ified Signal:    +1 443-546-8752
Tor+XMPP+OTR:        lattera@is.a.hacker.sx
GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE

--vxzaspxr2v4rrzcc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlwb8k0ACgkQaoRlj1JF
bu5p+Q/+IMWdCVIGQhoArzJtoyfLhyPVGAWBlxQW8Wz/+80lD7yXu0rGUvQjqFgq
w36z4knfdDnGWZz10mExFmjLTDjA620sj9iLYAuJ/tJ2ZHaiPm3B+0+gyZNls2v3
Ku1NIEBrC0wSSvOOWa5xlcUfoVAqYBVBHYHuaU0iv80lNG7mhTorKnVI93TvdHNe
mJGj6sHk1RTOM+WAlryhjh7pJFLKsrvEMvtlruHXo1LojNGRaZ7KOt/zrbCABUvM
DsgQRHYuHjTHcGoKExj1PIoQxn3cnrgnMGhqlRRsKdIhefUbQMp9sRwMlJn7dQk/
F5Ei50ie5MFxyniecXEyaFFYBbdBCPVyjU52wLZp4CF+cLq42/x7R4atCbhW3q36
tA0ba8AoV8KHEhtfaTUp647eQvO1ADjeG5HebWV7SpAc2AxcP3aq7J+wrrAJGHRC
ms8r7PSF1zvGAPsK36pS1wtaMHqOYulgj7/iNexEDjxamGbuqgoxMa08qxTrOnRg
iYsdSUSN9pp83ezz5xBgv+oXtbjBo6RHvcfZxLDDfP7xFyNjKwaiuUq5i2O3eSXu
yc78X+XYSI/0S0d+rMlHZ9eevLEOJf+s75QvsQbx2LmTzTPoT3geDbyv2ir+T3pC
NZ1tw2iTB/G0QzD4jbfEKONLdQTxQPfBVe+1FODQaHGsJnskth4=
=BxUu
-----END PGP SIGNATURE-----

--vxzaspxr2v4rrzcc--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181220194941.wikdor2wnsr56g4n>