Date: Sat, 29 Oct 2005 03:28:57 +0800 From: Xin LI <delphij@frontfree.net> To: Mohan Srinivasan <mohan_srinivasan@yahoo.com> Cc: freebsd-current@FreeBSD.org, re@FreeBSD.org Subject: Re: [RELENG_6] NFS panic on locking against myself Message-ID: <20051028192857.GA92246@frontfree.net> In-Reply-To: <20051028172249.66549.qmail@web31806.mail.mud.yahoo.com> References: <20051028165314.GA89706@frontfree.net> <20051028172249.66549.qmail@web31806.mail.mud.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--wRRV7LY7NUeQGEoC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Oct 28, 2005 at 10:22:49AM -0700, Mohan Srinivasan wrote:
> I saw this once too. The following change should fix this.
>=20
> @@ -965,7 +969,7 @@
> nfsmout:
> if (error) {
> if (newvp !=3D NULLVP) {
> - vrele(newvp);
> + vput(newvp);
> *vpp =3D NULLVP;
> }
> if ((cnp->cn_nameiop =3D=3D CREATE || cnp->cn_nameiop =3D=
=3D RENAME) &&
>=20
> Will check it into current soon.
Ah!! Thanks for this, without your confirm I was still thinking about
whether it's appropriate to replace the vrele() with vput()...
To re@: Could we wait for some day to settle this change?
Cheers,
--=20
Xin LI <delphij frontfree net> http://www.delphij.net/
See complete headers for GPG key and other information.
--wRRV7LY7NUeQGEoC
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFDYnv5/cVsHxFZiIoRAtUEAJ9pwv4kfqXp0Pz9FDi8E40jniYPjQCZAcP8
roCMNr+gpuxR0IOqh4rtZII=
=O4Oz
-----END PGP SIGNATURE-----
--wRRV7LY7NUeQGEoC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051028192857.GA92246>