Date: Wed, 5 Feb 2025 20:46:21 GMT From: Michael Tuexen <tuexen@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: ed530aaa4722 - stable/13 - TCP BBR: fix integer overflow Message-ID: <202502052046.515KkLQY084617@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=ed530aaa4722b0b7bacc25735699f3603a613318 commit ed530aaa4722b0b7bacc25735699f3603a613318 Author: Michael Tuexen <tuexen@FreeBSD.org> AuthorDate: 2025-01-03 18:44:43 +0000 Commit: Michael Tuexen <tuexen@FreeBSD.org> CommitDate: 2025-02-05 20:31:38 +0000 TCP BBR: fix integer overflow Use 64-bit arithmetic. Reviewed by: rrs CID: 1523806 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48302 (cherry picked from commit 88766e7af52bbde32b14ad48fb76798a3ba4650c) --- sys/netinet/tcp_stacks/bbr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c index 07430a0564d0..a8c2ad547a5d 100644 --- a/sys/netinet/tcp_stacks/bbr.c +++ b/sys/netinet/tcp_stacks/bbr.c @@ -3857,7 +3857,7 @@ bbr_post_recovery(struct tcpcb *tp) else if (bbr->r_ctl.rc_delivered == 0) lr2use = 1000; else { - lr2use = bbr->r_ctl.rc_lost * 1000; + lr2use = (uint64_t)bbr->r_ctl.rc_lost * (uint64_t)1000; lr2use /= bbr->r_ctl.rc_delivered; } lr2use += bbr->r_ctl.recovery_lr;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502052046.515KkLQY084617>