Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 20 Jan 2007 14:54:02 +0100
From:      "Simon L. Nielsen" <simon@FreeBSD.org>
To:        Pawel Jakub Dawidek <pjd@FreeBSD.org>
Cc:        freebsd-security@freebsd.org, freebsd-stable@freebsd.org, Colin Percival <cperciva@freebsd.org>
Subject:   Re: Improving FreeBSD-SA-07:01.jail fix [was: HEADS UP: Re: FreeBSD Security Advisory FreeBSD-SA-07:01.jail]
Message-ID:  <20070120135401.GB971@zaphod.nitro.dk>
In-Reply-To: <20070120130308.GD6697@garage.freebsd.pl>
References:  <200701111841.l0BIfWOn015231@freefall.freebsd.org> <45A6DB76.40800@freebsd.org> <20070113112937.GI90718@garage.freebsd.pl> <20070120122432.GA971@zaphod.nitro.dk> <20070120130308.GD6697@garage.freebsd.pl>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2007.01.20 14:03:08 +0100, Pawel Jakub Dawidek wrote:
> On Sat, Jan 20, 2007 at 01:24:33PM +0100, Simon L. Nielsen wrote:
> [...]
> > BTW. with regard to the console.log file I really don't think it
> > should be put back inside the jail unless it's possible to make the
> > generation of the file entirely inside the jail since it's just not
> > worth the risk/complexity.  I think it should be possible to do this
> > with jail(8) in -CURRENT (see -J flag), but:
> 
> When -J operates on a file inside a jail, it create the same security
> hole as the one from security advisory, because it opens a file before
> calling jail(2).

My thought with using -J was not place the info about jid in a file
outside the jail root, basically (pseudo code):

	_tmpfile=`mktemp...`
	jail -J $_tmpfile "sh /etc/rc > /var/log/console.log"
	_jid=`cat $_tmpfile | something`

At least that was what I thought might be possible with the -J switch
when I noticed it existed.  In any case, actually coding this,
verifying that it works and is safe is left up to anyone who cares
about having console.log inside the jail.

-- 
Simon L. Nielsen



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070120135401.GB971>