Date: Wed, 24 Mar 2010 07:10:03 GMT From: Garrett Cooper <yanegomi@gmail.com> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/121165: pkg_add(1) prints a weird message: PKG_TMPDIR environment variable to a location with at least 0 bytes Message-ID: <201003240710.o2O7A3mG034815@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/121165; it has been noted by GNATS.
From: Garrett Cooper <yanegomi@gmail.com>
To: bug-followup@FreeBSD.org, yuri@tsoft.com
Cc:
Subject: Re: bin/121165: pkg_add(1) prints a weird message: PKG_TMPDIR
environment variable to a location with at least 0 bytes
Date: Wed, 24 Mar 2010 00:06:09 -0700
--001485e8edde93919604828690c9
Content-Type: text/plain; charset=ISO-8859-1
Apparently the compiler missed the missing format qualifier after
the `stack overflow' format string modification because
-Wno-format-strings is specified in the default system CFLAGS (not
sure where but it's being set in /usr/share/mk...). Sorry for the
noise -- here's a correct patch -- I also removed an unneeded newline
in an err(3) call.
Thanks,
-Garrett
--001485e8edde93919604828690c9
Content-Type: application/octet-stream; name="bin.121165.diff"
Content-Disposition: attachment; filename="bin.121165.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g75shkgx0
SW5kZXg6IGRlbGV0ZS9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZGVsZXRlL21haW4uYwkocmV2aXNp
b24gMjA1MTU5KQorKysgZGVsZXRlL21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtMzcsNiArMzcs
OCBAQAogQm9vbGVhbglSZWN1cnNpdmUJPSBGQUxTRTsKIG1hdGNoX3QJTWF0Y2hUeXBlCT0gTUFU
Q0hfR0xPQjsKIAorY2hhcgkqcHJvZ25hbWUJPSBOVUxMOworCiBzdGF0aWMgdm9pZCB1c2FnZSh2
b2lkKTsKIAogc3RhdGljIGNoYXIgb3B0c1tdID0gImFkRGZHaGlucDpydnhYIjsKQEAgLTY3LDYg
KzY5LDggQEAKICAgICBjb25zdCBjaGFyICp0bXA7CiAgICAgc3RydWN0IHN0YXQgc3RhdF9zOwog
CisgICAgaWYgKChwcm9nbmFtZSA9IGJhc2VuYW1lKGFyZ3ZbMF0pKSA9PSBOVUxMKQorCWVycihF
WElUX0ZBSUxVUkUsICJiYXNlbmFtZSIpOwogICAgIHBrZ3MgPSBzdGFydCA9IGFyZ3Y7CiAgICAg
d2hpbGUgKChjaCA9IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsIG9wdHMsIGxvbmdvcHRzLCBOVUxM
KSkgIT0gLTEpCiAJc3dpdGNoKGNoKSB7CkluZGV4OiBjcmVhdGUvbWFpbi5jCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIGNyZWF0ZS9tYWluLmMJKHJldmlzaW9uIDIwNTE1OSkKKysrIGNyZWF0ZS9tYWluLmMJKHdv
cmtpbmcgY29weSkKQEAgLTQ1LDYgKzQ1LDcgQEAKIGludAlIZWxwCQk9IEZBTFNFOwogZW51bSB6
aXBwZXIJWmlwcGVyICA9IEJaSVAyOwogCitjaGFyCSpwcm9nbmFtZQk9IE5VTEw7CiAKIHN0YXRp
YyB2b2lkIHVzYWdlKHZvaWQpOwogCkBAIC03Miw2ICs3Myw4IEBACiAgICAgaW50IGNoOwogICAg
IGNoYXIgKipwa2dzLCAqKnN0YXJ0LCAqdG1wOwogCisgICAgaWYgKChwcm9nbmFtZSA9IGJhc2Vu
YW1lKGFyZ3ZbMF0pKSA9PSBOVUxMKQorCWVycihFWElUX0ZBSUxVUkUsICJiYXNlbmFtZSIpOwog
ICAgIHBrZ3MgPSBzdGFydCA9IGFyZ3Y7CiAgICAgd2hpbGUgKChjaCA9IGdldG9wdF9sb25nKGFy
Z2MsIGFyZ3YsIG9wdHMsIGxvbmdvcHRzLCBOVUxMKSkgIT0gLTEpCiAJc3dpdGNoKGNoKSB7Cklu
ZGV4OiB2ZXJzaW9uL21haW4uYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB2ZXJzaW9uL21haW4uYwkocmV2aXNp
b24gMjA1MTU5KQorKysgdmVyc2lvbi9tYWluLmMJKHdvcmtpbmcgY29weSkKQEAgLTM2LDYgKzM2
LDggQEAKIEJvb2xlYW4gVXNlSU5ERVhPbmx5ID0gRkFMU0U7CiBCb29sZWFuIFNob3dPcmlnaW4g
PSBGQUxTRTsKIAorY2hhcgkqcHJvZ25hbWUJPSBOVUxMOworCiBzdGF0aWMgdm9pZCB1c2FnZSh2
b2lkKTsKIAogc3RhdGljIGNoYXIgb3B0c1tdID0gImRJaGw6TDpxczpYdFRPOm92IjsKQEAgLTY3
LDYgKzY5LDggQEAKIAljbXAgPSB2ZXJzaW9uX21hdGNoKGFyZ3ZbM10sIGFyZ3ZbMl0pOwogCWV4
aXQoY21wID09IDEgPyAwIDogMSk7CiAgICAgfQorICAgIGlmICgocHJvZ25hbWUgPSBiYXNlbmFt
ZShhcmd2WzBdKSkgPT0gTlVMTCkKKwllcnIoRVhJVF9GQUlMVVJFLCAiYmFzZW5hbWUiKTsKICAg
ICBlbHNlIHdoaWxlICgoY2ggPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCBvcHRzLCBsb25nb3B0
cywgTlVMTCkpICE9IC0xKSB7CiAJc3dpdGNoKGNoKSB7CiAJY2FzZSAndic6CkluZGV4OiBsaWIv
cGVuLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gbGliL3Blbi5jCShyZXZpc2lvbiAyMDUxNTkpCisrKyBsaWIv
cGVuLmMJKHdvcmtpbmcgY29weSkKQEAgLTYyLDEwICs2MiwxMSBAQAogCWNsZWFudXAoMCk7CiAJ
aHVtYW5pemVfbnVtYmVyKGh1bWJ1Ziwgc2l6ZW9mIGh1bWJ1Ziwgc3osICIiLCBITl9BVVRPU0NB
TEUsCiAJICAgIEhOX05PU1BBQ0UpOwotCWVycngoMiwKLSIlczogY2FuJ3QgZmluZCBlbm91Z2gg
dGVtcG9yYXJ5IHNwYWNlIHRvIGV4dHJhY3QgdGhlIGZpbGVzLCBwbGVhc2Ugc2V0IHlvdXJcbiIK
LSJQS0dfVE1QRElSIGVudmlyb25tZW50IHZhcmlhYmxlIHRvIGEgbG9jYXRpb24gd2l0aCBhdCBs
ZWFzdCAlcyBieXRlc1xuIgotImZyZWUiLCBfX2Z1bmNfXywgaHVtYnVmKTsKKwkvKiBYWFg6IE1h
aW50YWluIDgwIGNvbHVtbiB3aWR0aCBpbiB0aGUgZXJyb3IgbWVzc2FnZS4gKi8KKwllcnJ4KEVY
SVRfRkFJTFVSRSwKKwkgICAgIiVzLiVzOiBub3QgZW5vdWdoIHRlbXBvcmFyeSBzcGFjZSB0byBl
eHRyYWN0IHRoZSBmaWxlczsgc2V0IFBLR19UTVBESVIgaW5cbiIKKwkgICAgInlvdXIgZW52aXJv
bm1lbnQgdG8gYSBsb2NhdGlvbiB3aXRoIGF0IGxlYXN0ICVzIGJ5dGVzIGZyZWUiLAorCSAgICBw
cm9nbmFtZSwgX19mdW5jX18sIGh1bWJ1Zik7CiAJcmV0dXJuIE5VTEw7CiAgICAgfQogICAgIHJl
dHVybiBwZW47CkBAIC03OSw3ICs4MCw3IEBACiBwdXNoUGVuKGNvbnN0IGNoYXIgKnBlbikKIHsK
ICAgICBpZiAoKytwZGVwdGggPT0gTUFYX1NUQUNLKQotCWVycngoMiwgIiVzOiBzdGFjayBvdmVy
Zmxvdy5cbiIsIF9fZnVuY19fKTsKKwllcnJ4KDIsICIlcy4lczogc3RhY2sgb3ZlcmZsb3cuIiwg
cHJvZ25hbWUsIF9fZnVuY19fKTsKICAgICBwc3RhY2tbcGRlcHRoXSA9IHN0cmR1cChwZW4pOwog
CiAgICAgcmV0dXJuIHBzdGFja1twZGVwdGhdOwpAQCAtMTMxLDkgKzEzMiwxMCBAQAogICAgIGlm
IChtaW5fZnJlZShwZW4pIDwgc3opIHsKIAlybWRpcihwZW4pOwogCWNsZWFudXAoMCk7Ci0JZXJy
eCgyLCAiJXM6IG5vdCBlbm91Z2ggZnJlZSBzcGFjZSB0byBjcmVhdGUgJyVzJy5cbiIKKwllcnJ4
KDIsICIlcy4lczogbm90IGVub3VnaCBmcmVlIHNwYWNlIHRvIGNyZWF0ZSAnJXMnLlxuIgogCSAg
ICAgIlBsZWFzZSBzZXQgeW91ciBQS0dfVE1QRElSIGVudmlyb25tZW50IHZhcmlhYmxlIHRvIGEg
bG9jYXRpb25cbiIKLQkgICAgICJ3aXRoIG1vcmUgc3BhY2UgYW5kXG50cnkgdGhlIGNvbW1hbmQg
YWdhaW4iLCBfX2Z1bmNfXywgcGVuKTsKKwkgICAgICJ3aXRoIG1vcmUgc3BhY2UgYW5kXG50cnkg
dGhlIGNvbW1hbmQgYWdhaW4iLCBwcm9nbmFtZSwgX19mdW5jX18sCisJICAgICBwZW4pOwogICAg
IH0KIAogICAgIGlmICghZ2V0Y3dkKGN3ZCwgRklMRU5BTUVfTUFYKSkgewpAQCAtMTQzLDcgKzE0
NSw3IEBACiAKICAgICBpZiAoY2hkaXIocGVuKSA9PSBGQUlMKSB7CiAJY2xlYW51cCgwKTsKLQll
cnJ4KDIsICIlczogY2FuJ3QgY2hkaXIgdG8gJyVzJyIsIF9fZnVuY19fLCBwZW4pOworCWVycngo
MiwgIiVzOiVzOiBjYW4ndCBjaGRpciB0byAnJXMnIiwgcHJvZ25hbWUsIF9fZnVuY19fLCBwZW4p
OwogICAgIH0KIAogICAgIHN0cmNweShQZW5Mb2NhdGlvbiwgcGVuKTsKQEAgLTE2NywxMSArMTY5
LDExIEBACiAKICAgICBpZiAoY2hkaXIoUGVuTG9jYXRpb24pID09IEZBSUwpIHsKIAljbGVhbnVw
KDApOwotCWVycngoMiwgIiVzOiBjYW4ndCBjaGRpciBiYWNrIHRvICclcyciLCBfX2Z1bmNfXywg
UGVuTG9jYXRpb24pOworCWVycngoMiwgIiVzLiVzOiBjYW4ndCBjaGRpciBiYWNrIHRvICclcyci
LCBwcm9nbmFtZSwgX19mdW5jX18sIFBlbkxvY2F0aW9uKTsKICAgICB9CiAKICAgICBpZiAobGVm
dFswXSA9PSAnLycgJiYgdnN5c3RlbSgiL2Jpbi9ybSAtcmYgJXMiLCBsZWZ0KSkKLQl3YXJueCgi
Y291bGRuJ3QgcmVtb3ZlIHRlbXBvcmFyeSBkaXIgJyVzJyIsIGxlZnQpOworCXdhcm54KCIlcy4l
czogY291bGRuJ3QgcmVtb3ZlIHRlbXBvcmFyeSBkaXIgJyVzJyIsIHByb2duYW1lLCBfX2Z1bmNf
XywgbGVmdCk7CiAgICAgc2lnbmFsKFNJR0lOVCwgb2xkc2lnKTsKIAogICAgIHJldHVybiAxOwpA
QCAtMTgzLDcgKzE4NSw3IEBACiAgICAgc3RydWN0IHN0YXRmcyBidWY7CiAKICAgICBpZiAoc3Rh
dGZzKHRtcGRpciwgJmJ1ZikgIT0gMCkgewotCXdhcm4oInN0YXRmcyIpOworCXdhcm4oIiVzLiVz
OiBzdGF0ZnMiLCBwcm9nbmFtZSwgX19mdW5jX18pOwogCXJldHVybiAtMTsKICAgICB9CiAgICAg
cmV0dXJuIChvZmZfdClidWYuZl9iYXZhaWwgKiAob2ZmX3QpYnVmLmZfYnNpemU7CkluZGV4OiBs
aWIvbGliLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gbGliL2xpYi5oCShyZXZpc2lvbiAyMDUxNTkpCisrKyBs
aWIvbGliLmgJKHdvcmtpbmcgY29weSkKQEAgLTMwLDYgKzMwLDggQEAKICNpbmNsdWRlIDxzeXMv
cXVldWUuaD4KICNpbmNsdWRlIDxjdHlwZS5oPgogI2luY2x1ZGUgPGRpcmVudC5oPgorI2luY2x1
ZGUgPGVyci5oPgorI2luY2x1ZGUgPGxpYmdlbi5oPgogI2luY2x1ZGUgPHN0ZGFyZy5oPgogI2lu
Y2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CkBAIC0yMzksOSArMjQxLDEwIEBA
CiBpbnQJCXZlcnNpb25fY21wKGNvbnN0IGNoYXIgKiwgY29uc3QgY2hhciAqKTsKIAogLyogRXh0
ZXJucyAqLworZXh0ZXJuIGNoYXIJKnByb2duYW1lOwogZXh0ZXJuIEJvb2xlYW4JUXVpZXQ7CiBl
eHRlcm4gQm9vbGVhbglGYWtlOwotZXh0ZXJuIEJvb2xlYW4gIEZvcmNlOworZXh0ZXJuIEJvb2xl
YW4JRm9yY2U7CiBleHRlcm4gaW50CUF1dG9BbnN3ZXI7CiBleHRlcm4gaW50CVZlcmJvc2U7CiAK
SW5kZXg6IGFkZC9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gYWRkL21haW4uYwkocmV2aXNpb24gMjA1
MTU5KQorKysgYWRkL21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAsOCBAQAogCiBj
aGFyCSoqcGtnczsKIAorY2hhcgkqcHJvZ25hbWUJPSBOVUxMOworCiBzdHJ1Y3QgewogCWludCBs
b3d2ZXI7CS8qIExvd2VzdCB2ZXJzaW9uIG51bWJlciB0byBtYXRjaCAqLwogCWludCBoaXZlcjsJ
LyogSGlnaGVzdCB2ZXJzaW9uIG51bWJlciB0byBtYXRjaCAqLwpAQCAtMTI4LDkgKzEzMCwxMiBA
QAogICAgIHN0YXRpYyBjaGFyIHRlbXBwYWNrYWdlcm9vdFtNQVhQQVRITEVOXTsKICAgICBzdGF0
aWMgY2hhciBwa2dhZGRwYXRoW01BWFBBVEhMRU5dOwogCi0gICAgaWYgKCphcmd2WzBdICE9ICcv
JyAmJiBzdHJjaHIoYXJndlswXSwgJy8nKSAhPSBOVUxMKQotCVBrZ0FkZENtZCA9IHJlYWxwYXRo
KGFyZ3ZbMF0sIHBrZ2FkZHBhdGgpOwotICAgIGVsc2UKKyAgICBpZiAoKHByb2duYW1lID0gYmFz
ZW5hbWUoYXJndlswXSkpID09IE5VTEwpCisJZXJyKEVYSVRfRkFJTFVSRSwgImJhc2VuYW1lIik7
CisgICAgaWYgKCphcmd2WzBdICE9ICcvJyAmJiBzdHJjaHIoYXJndlswXSwgJy8nKSAhPSBOVUxM
KSB7CisJaWYgKChQa2dBZGRDbWQgPSByZWFscGF0aChhcmd2WzBdLCBwa2dhZGRwYXRoKSkgPT0g
TlVMTCkKKwkgICAgZXJyKEVYSVRfRkFJTFVSRSwgInJlYWxwYXRoIik7CisgICAgfSBlbHNlCiAJ
UGtnQWRkQ21kID0gYXJndlswXTsKIAogICAgIHN0YXJ0ID0gYXJndjsKSW5kZXg6IGluZm8vbWFp
bi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIGluZm8vbWFpbi5jCShyZXZpc2lvbiAyMDUxNTkpCisrKyBpbmZv
L21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtMzksNiArMzksOCBAQAogQm9vbGVhbiBLZWVwUGFj
a2FnZQk9IEZBTFNFOwogc3RydWN0IHdoaWNoX2hlYWQgKndoZWFkOwogCitjaGFyCSpwcm9nbmFt
ZQk9IE5VTEw7CisKIHN0YXRpYyB2b2lkIHVzYWdlKHZvaWQpOwogCiBzdGF0aWMgY2hhciBvcHRz
W10gPSAiYWJjZERlOkVmZ0doaUlqa0tsOkxtb086cFBxUXJSc3Q6dlZXOnhYIjsKQEAgLTczLDYg
Kzc1LDggQEAKIAllcnIoMiwgTlVMTCk7CiAgICAgVEFJTFFfSU5JVCh3aGVhZCk7CiAKKyAgICBp
ZiAoKHByb2duYW1lID0gYmFzZW5hbWUoYXJndlswXSkpID09IE5VTEwpCisJZXJyKEVYSVRfRkFJ
TFVSRSwgImJhc2VuYW1lIik7CiAgICAgcGtncyA9IHN0YXJ0ID0gYXJndjsKICAgICBpZiAoYXJn
YyA9PSAxKSB7CiAJTWF0Y2hUeXBlID0gTUFUQ0hfQUxMOwo=
--001485e8edde93919604828690c9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003240710.o2O7A3mG034815>