Date: Wed, 7 Mar 2012 08:08:36 +0000 (UTC) From: Konstantin Belousov <kib@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org Subject: svn commit: r232647 - stable/9/sys/fs/nullfs Message-ID: <201203070808.q2788adC082330@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kib Date: Wed Mar 7 08:08:36 2012 New Revision: 232647 URL: http://svn.freebsd.org/changeset/base/232647 Log: MFC r232304: Document that null_nodeget() cannot take shared-locked lowervp due to insmntque() requirements. Modified: stable/9/sys/fs/nullfs/null_subr.c Directory Properties: stable/9/sys/ (props changed) Modified: stable/9/sys/fs/nullfs/null_subr.c ============================================================================== --- stable/9/sys/fs/nullfs/null_subr.c Wed Mar 7 08:07:28 2012 (r232646) +++ stable/9/sys/fs/nullfs/null_subr.c Wed Mar 7 08:08:36 2012 (r232647) @@ -209,7 +209,11 @@ null_nodeget(mp, lowervp, vpp) struct vnode *vp; int error; - ASSERT_VOP_LOCKED(lowervp, "lowervp"); + /* + * The insmntque1() call below requires the exclusive lock on + * the nullfs vnode. + */ + ASSERT_VOP_ELOCKED(lowervp, "lowervp"); KASSERT(lowervp->v_usecount >= 1, ("Unreferenced vnode %p\n", lowervp)); /* Lookup the hash firstly */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203070808.q2788adC082330>