Date: Thu, 21 Feb 2002 00:51:48 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Bruce Evans <bde@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/sys/kern sys_process.c Message-ID: <XFMail.020221005148.jhb@FreeBSD.org> In-Reply-To: <200202210437.g1L4btc69989@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21-Feb-02 Bruce Evans wrote: > bde 2002/02/20 20:37:55 PST > > Modified files: > sys/kern sys_process.c > Log: > Recover bits that were lost in transition in rev.1.76: > - P_INMEM checks in all the functions. P_INMEM must be checked because > PHOLD() is broken. The old bits had bogus locking (using sched_lock) > to lock P_INMEM. After removing the P_INMEM checks, we were left with > just the bogus locking. > - large comments. They were too large, but better than nothing. I would much prefer that we fix phold/prele rather than do the bogus PS_INMEM checks if possible. > Remove obfuscations that were gained in transition in rev.1.76: > - PROC_REG_ACTION() is even more of an obfuscation than PROC_ACTION(). > > The change copies procfs_machdep.c rev.1.22 of i386/procfs_machdep.c > verbatim except for "fixing" the old-style function headers and adjusting > function names and comments. It doesn't remove the bogus locking. > > Approved by: des > > Revision Changes Path > 1.80 +77 -16 src/sys/kern/sys_process.c -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.020221005148.jhb>