Date: Tue, 20 Jul 2004 01:45:26 -0700 (PDT) From: Jeremy Chadwick <freebsd@jdc.parodius.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/69334: Fix for /suphp.log (should be /var/log/suphp.log) Message-ID: <200407200845.i6K8jQcT017352@pentarou.parodius.com> Resent-Message-ID: <200407200850.i6K8oLN7013770@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 69334
>Category: ports
>Synopsis: Fix for /suphp.log (should be /var/log/suphp.log)
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Tue Jul 20 08:50:21 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Jeremy Chadwick
>Release: FreeBSD 4.10-PRERELEASE i386
>Organization:
Parodius Networking
>Environment:
System: FreeBSD pentarou.parodius.com 4.10-PRERELEASE FreeBSD 4.10-PRERELEASE #0: Wed May 5 03:33:17 PDT 2004 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386
>Description:
The present suphp port has some incorrect framework for specification
of where the logfile points, assuming the user DOES NOT specify the
LOG_PATH variable upon build (by default, it's empty). The logfile
will end up in / (a.k.a. /suphp.log), which is naughty.
The included Makefile patch should fix things up by removing LOG_PATH
and WITH_LOGNAME, and using a single variable: LOGFILE, which by
default points to /var/log/suphp.log.
>How-To-Repeat:
Build suphp without defining LOG_PATH.
>Fix:
See attached patch below.
--- Makefile.orig Thu Jul 15 15:13:36 2004
+++ Makefile Tue Jul 20 01:36:37 2004
@@ -19,8 +19,7 @@
USE_APACHE= yes
CONFLICTS= mod_php4-4* php-4.*
-LOG_PATH?= ${WITH_LOGPATH}
-WITH_LOGNAME?= suphp.log
+LOGFILE?= /var/log/suphp.log
PHP_PATH?= ${LOCALBASE}/bin/php
APACHE_USER?= ${WWWOWN}
MIN_UID?= 80
@@ -31,7 +30,7 @@
LANG= en de
CONFIGURE_ARGS+= --with-php=${PHP_PATH} \
- --with-logfile=${LOG_PATH}/${WITH_LOGNAME} \
+ --with-logfile=${LOGFILE} \
--with-apache-user=${APACHE_USER} \
--with-min-gid=${MIN_UID} \
--with-min-uid=${MIN_GID} \
@@ -52,9 +51,6 @@
.endif
## WITH_SETID_MODE: Mode to use for setting UID/GID.
CONFIGURE_ARGS+= --with-setid-mode=${WITH_SETID_MODE}
-## WITH_LOGPATH (formerly known as LOG_PATH): logging directory
-## (default: /var/log)
-## WITH_LOGNAME: log file name (default suphp.log)
.include <bsd.port.pre.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407200845.i6K8jQcT017352>