Date: Sat, 10 Sep 2011 12:35:51 +0100 From: "Robert N. M. Watson" <rwatson@freebsd.org> To: Hans Petter Selasky <hselasky@c2i.net> Cc: "svn-src-stable@freebsd.org" <svn-src-stable@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-stable-8@freebsd.org" <svn-src-stable-8@freebsd.org> Subject: Re: svn commit: r225458 - in stable/8/sys: dev/usb dev/usb/quirk dev/usb/storage sys Message-ID: <D2195F50-8958-41DC-AA26-AEF3156F369B@freebsd.org> In-Reply-To: <201109101310.24841.hselasky@c2i.net> References: <201109090744.p897iE9x027234@svn.freebsd.org> <alpine.BSF.2.00.1109101149120.62958@fledge.watson.org> <201109101310.24841.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10 Sep 2011, at 12:10, Hans Petter Selasky wrote: >> For most other classes of hardware device driver framework KPIs -- >> especially things like PCI bus attachment, busdma, CAM, ifnet, and = GEOM >> frameworks, our MFC rules would strictly disallow this sort of = change, on >> the grounds that it is our KBI policy that we not break common = classes of >> third-party device drivers (i.e., require them to be recompiled). My >> suspicion is that we should be applying the same rules to the USB >> framework -- however, I don't know if we have any third-party USB = device >> drivers? >>=20 >> (If we do, then this change should not have been MFC'd.) >=20 > I understand your point. The change is not breaking any KPIs towards=20= > userspace. The structure in question is only used within the kernel = and kernel=20 > modules. Right -- exactly my point. If this change breaks third-party compiled = USB device drivers, then our current approach to device driver KBIs does = not allow it to be MFC'd in this form. Are there ways you can = reformulate the change to avoid breaking those drivers? Sometimes this = can be done by adding new symbols, rather than replacing currently = symbols, although mileage varies. Robert=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D2195F50-8958-41DC-AA26-AEF3156F369B>