Date: Fri, 27 Dec 2019 10:28:46 -0600 From: Kyle Evans <kevans@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r356092 - head/sys/dev/kbdmux Message-ID: <CACNAnaELpkUxBmOc5xiApisUKfGsdkq8CBAY%2BwWWKEw5-fse2g@mail.gmail.com> In-Reply-To: <62d80c6e-f0c0-05bb-cb22-b6cf40d4c06f@selasky.org> References: <201912261725.xBQHPq8u076460@repo.freebsd.org> <62d80c6e-f0c0-05bb-cb22-b6cf40d4c06f@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 27, 2019 at 9:04 AM Hans Petter Selasky <hps@selasky.org> wrote: > > TODO: > > Is there a way to distinguish between key events which are key-presses > and events which are auto-repeated key-presses? > At the risk of asking a dumb question, where are you wanting to make this distinction at? I haven't thought much about it, but it looks like we could either burn the last keyflag for it (we haven't added one in at least 13 years) or use `NOKEY | keychar` as an indicator for this, as I think that would still make logical sense. NOKEY is currently used a standalone value for 'no key pressed marker', and everything in-tree seems to check (read_char() == NOKEY) rather than (KEYFLAGS(read_char()) == NOKEY) for the current interpretation. Thanks, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaELpkUxBmOc5xiApisUKfGsdkq8CBAY%2BwWWKEw5-fse2g>