Date: Thu, 20 Oct 2011 20:22:12 +0100 From: Chris Rees <crees@freebsd.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/databases/postgresql82-server Makefile ports/databases/postgresql83-server Makefile ports/databases/postgresql84-server Makefile ports/databases/postgresql90-server Makefile ports/databases/postgresql91-server Makefile Message-ID: <CADLo839NHhrMesRxZ2VJredXAuSvDxEbZt_gFzrZbb-L7as3kw@mail.gmail.com> In-Reply-To: <20111020165609.GC85114@bonjour.sunpoet.net> References: <201110191829.p9JITw4t079235@repoman.freebsd.org> <20111020165609.GC85114@bonjour.sunpoet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 October 2011 17:56, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> wrote:
> On Wed, Oct 19, 2011 at 06:29:58PM +0000, Chris Rees wrote:
>> crees 2011-10-19 18:29:58 UTC
>>
>> FreeBSD ports repository
>>
>> Modified files:
>> databases/postgresql82-server Makefile
>> databases/postgresql83-server Makefile
>> databases/postgresql84-server Makefile
>> databases/postgresql90-server Makefile
>> databases/postgresql91-server Makefile
>> Log:
>> This time remember to bump PORTREVISION
>>
>> Revision Changes Path
>> 1.203 +1 -0 ports/databases/postgresql82-server/Makefile
>> 1.216 +1 -0 ports/databases/postgresql83-server/Makefile
>> 1.234 +1 -1 ports/databases/postgresql84-server/Makefile
>> 1.229 +1 -1 ports/databases/postgresql90-server/Makefile
>> 1.230 +1 -1 ports/databases/postgresql91-server/Makefile
>
> PORTREVISION for postgrsql family needs a litte bit more carefulness.
>
> Just a reminder that bumping PORTREVISION of postgresql*-server also affects
> other postgresql ports, esp. postgresql*-client and postgresql*-contrib. It
> would be better to check/set PORTREVISION=something for postgresql*-client
> and postgresql*-contrib.
>
> % grep PORTREVISION postgresql*-client/Makefile postgresql*-contrib/Makefile
> postgresql84-client/Makefile:PORTREVISION= 0
> postgresql90-client/Makefile:PORTREVISION= 0
> postgresql84-contrib/Makefile:PORTREVISION= 0
> postgresql90-contrib/Makefile:PORTREVISION= 0
>
> If we look further more, some ports' PORTREVISION (e.g. p5-postgresql-plperl
> and postgresql-plpython ...) should be reset to 0 along with the new
> postgresql releases.
>
> I suggest to add PORTREVISION=0 to ports which use postgresql*-server as
> MASTERDIR. e.g. postgresql{82|83|91}-{client|contrib}
>
While you're correct, this is definitely a job for the maintainer.
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo839NHhrMesRxZ2VJredXAuSvDxEbZt_gFzrZbb-L7as3kw>