Date: Tue, 26 Sep 2023 08:51:45 -0600 From: Warner Losh <imp@bsdimp.com> To: Mateusz Guzik <mjg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag Message-ID: <CANCZdformxVqA0LjzOpWosgd-RUCP0r3UE=4rk9W0E6pGOGRfA@mail.gmail.com> In-Reply-To: <202309261437.38QEbWmw002059@gitrepo.freebsd.org> References: <202309261437.38QEbWmw002059@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Can you put this back? It is still useful. I have automated scripts that look for this pattern to find the version of a core dump. There are no other ways that are as reliable to find this data. Some other heuristics exist, but my experience with snagging data from maybe a thousand core dumps from $WORK's network found issues in all the alternatives. It's why I didn't whack it already. Even though the text says SCCS which is prehistory for this project, it's still in use today. Warner On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik <mjg@freebsd.org> wrote: > The branch main has been updated by mjg: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=e6dc6a27230f836a131118326731b7c5fd417723 > > commit e6dc6a27230f836a131118326731b7c5fd417723 > Author: Mateusz Guzik <mjg@FreeBSD.org> > AuthorDate: 2023-09-26 14:36:51 +0000 > Commit: Mateusz Guzik <mjg@FreeBSD.org> > CommitDate: 2023-09-26 14:36:51 +0000 > > sys/conf/newvers.sh: whack sccs tag > > In the same spirit as removing cvs $FreeBSD$ tags. > > Sponsored by: Rubicon Communications, LLC ("Netgate") > --- > sys/conf/newvers.sh | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh > index 73fd6857d307..18b1817ca287 100644 > --- a/sys/conf/newvers.sh > +++ b/sys/conf/newvers.sh > @@ -311,11 +311,9 @@ fi > > vers_content_new=$(cat << EOF > $COPYRIGHT > -#define SCCSSTR "@(#)${VERINFO}" > #define VERSTR "${VERSTR}" > #define RELSTR "${RELEASE}" > > -char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] = SCCSSTR; > char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] = VERSTR; > char compiler_version[] = "${compiler_v}"; > char ostype[] = "${TYPE}"; > [-- Attachment #2 --] <div dir="auto">Can you put this back? It is still useful. I have automated scripts that look for this pattern to find the version of a core dump. There are no other ways that are as reliable to find this data. Some other heuristics exist, but my experience with snagging data from maybe a thousand core dumps from $WORK's network found issues in all the alternatives. It's why I didn't whack it already. Even though the text says SCCS which is prehistory for this project, it's still in use today.<div dir="auto"><br></div><div dir="auto">Warner</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik <<a href="mailto:mjg@freebsd.org">mjg@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The branch main has been updated by mjg:<br> <br> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=e6dc6a27230f836a131118326731b7c5fd417723" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=e6dc6a27230f836a131118326731b7c5fd417723</a><br>; <br> commit e6dc6a27230f836a131118326731b7c5fd417723<br> Author: Mateusz Guzik <mjg@FreeBSD.org><br> AuthorDate: 2023-09-26 14:36:51 +0000<br> Commit: Mateusz Guzik <mjg@FreeBSD.org><br> CommitDate: 2023-09-26 14:36:51 +0000<br> <br> sys/conf/newvers.sh: whack sccs tag<br> <br> In the same spirit as removing cvs $FreeBSD$ tags.<br> <br> Sponsored by: Rubicon Communications, LLC ("Netgate")<br> ---<br> sys/conf/newvers.sh | 2 --<br> 1 file changed, 2 deletions(-)<br> <br> diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh<br> index 73fd6857d307..18b1817ca287 100644<br> --- a/sys/conf/newvers.sh<br> +++ b/sys/conf/newvers.sh<br> @@ -311,11 +311,9 @@ fi<br> <br> vers_content_new=$(cat << EOF<br> $COPYRIGHT<br> -#define SCCSSTR "@(#)${VERINFO}"<br> #define VERSTR "${VERSTR}"<br> #define RELSTR "${RELEASE}"<br> <br> -char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] = SCCSSTR;<br> char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] = VERSTR;<br> char compiler_version[] = "${compiler_v}";<br> char ostype[] = "${TYPE}";<br> </blockquote></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdformxVqA0LjzOpWosgd-RUCP0r3UE=4rk9W0E6pGOGRfA>