Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Sep 2023 08:51:45 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Mateusz Guzik <mjg@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>,  "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>,  "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>
Subject:   Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag
Message-ID:  <CANCZdformxVqA0LjzOpWosgd-RUCP0r3UE=4rk9W0E6pGOGRfA@mail.gmail.com>
In-Reply-To: <202309261437.38QEbWmw002059@gitrepo.freebsd.org>
References:  <202309261437.38QEbWmw002059@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000642dfa06064437b9
Content-Type: text/plain; charset="UTF-8"

Can you put this back? It is still useful. I have automated scripts that
look for this pattern to find the version of a core dump. There are no
other ways that are as reliable to find this data. Some other heuristics
exist, but my experience with snagging data from maybe a thousand core
dumps from $WORK's network found issues in all the alternatives. It's why I
didn't whack it already. Even though the text says SCCS which is prehistory
for this project, it's still in use today.

Warner

On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik <mjg@freebsd.org> wrote:

> The branch main has been updated by mjg:
>
> URL:
> https://cgit.FreeBSD.org/src/commit/?id=e6dc6a27230f836a131118326731b7c5fd417723
>
> commit e6dc6a27230f836a131118326731b7c5fd417723
> Author:     Mateusz Guzik <mjg@FreeBSD.org>
> AuthorDate: 2023-09-26 14:36:51 +0000
> Commit:     Mateusz Guzik <mjg@FreeBSD.org>
> CommitDate: 2023-09-26 14:36:51 +0000
>
>     sys/conf/newvers.sh: whack sccs tag
>
>     In the same spirit as removing cvs $FreeBSD$ tags.
>
>     Sponsored by:   Rubicon Communications, LLC ("Netgate")
> ---
>  sys/conf/newvers.sh | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh
> index 73fd6857d307..18b1817ca287 100644
> --- a/sys/conf/newvers.sh
> +++ b/sys/conf/newvers.sh
> @@ -311,11 +311,9 @@ fi
>
>  vers_content_new=$(cat << EOF
>  $COPYRIGHT
> -#define SCCSSTR "@(#)${VERINFO}"
>  #define VERSTR "${VERSTR}"
>  #define RELSTR "${RELEASE}"
>
> -char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] = SCCSSTR;
>  char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] = VERSTR;
>  char compiler_version[] = "${compiler_v}";
>  char ostype[] = "${TYPE}";
>

--000000000000642dfa06064437b9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Can you put this back? It is still useful. I have automat=
ed scripts that look for this pattern to find the version of a core dump. T=
here are no other ways that are as reliable to find this data. Some other h=
euristics exist, but my experience with snagging data from maybe a thousand=
 core dumps from $WORK&#39;s network found issues in all the alternatives. =
It&#39;s why I didn&#39;t whack it already. Even though the text says SCCS =
which is prehistory for this project, it&#39;s still in use today.<div dir=
=3D"auto"><br></div><div dir=3D"auto">Warner</div></div><br><div class=3D"g=
mail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Sep 26, 2023, 8:3=
7 AM Mateusz Guzik &lt;<a href=3D"mailto:mjg@freebsd.org">mjg@freebsd.org</=
a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 =
0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The branch main has b=
een updated by mjg:<br>
<br>
URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3De6dc6a27230f836a1=
31118326731b7c5fd417723" rel=3D"noreferrer noreferrer" target=3D"_blank">ht=
tps://cgit.FreeBSD.org/src/commit/?id=3De6dc6a27230f836a131118326731b7c5fd4=
17723</a><br>
<br>
commit e6dc6a27230f836a131118326731b7c5fd417723<br>
Author:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik &lt;mjg@FreeBSD.org&gt;<br>
AuthorDate: 2023-09-26 14:36:51 +0000<br>
Commit:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik &lt;mjg@FreeBSD.org&gt;<br>
CommitDate: 2023-09-26 14:36:51 +0000<br>
<br>
=C2=A0 =C2=A0 sys/conf/newvers.sh: whack sccs tag<br>
<br>
=C2=A0 =C2=A0 In the same spirit as removing cvs $FreeBSD$ tags.<br>
<br>
=C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0Rubicon Communications, LLC (&quot;=
Netgate&quot;)<br>
---<br>
=C2=A0sys/conf/newvers.sh | 2 --<br>
=C2=A01 file changed, 2 deletions(-)<br>
<br>
diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh<br>
index 73fd6857d307..18b1817ca287 100644<br>
--- a/sys/conf/newvers.sh<br>
+++ b/sys/conf/newvers.sh<br>
@@ -311,11 +311,9 @@ fi<br>
<br>
=C2=A0vers_content_new=3D$(cat &lt;&lt; EOF<br>
=C2=A0$COPYRIGHT<br>
-#define SCCSSTR &quot;@(#)${VERINFO}&quot;<br>
=C2=A0#define VERSTR &quot;${VERSTR}&quot;<br>
=C2=A0#define RELSTR &quot;${RELEASE}&quot;<br>
<br>
-char sccs[sizeof(SCCSSTR) &gt; 128 ? sizeof(SCCSSTR) : 128] =3D SCCSSTR;<b=
r>
=C2=A0char version[sizeof(VERSTR) &gt; 256 ? sizeof(VERSTR) : 256] =3D VERS=
TR;<br>
=C2=A0char compiler_version[] =3D &quot;${compiler_v}&quot;;<br>
=C2=A0char ostype[] =3D &quot;${TYPE}&quot;;<br>
</blockquote></div>

--000000000000642dfa06064437b9--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdformxVqA0LjzOpWosgd-RUCP0r3UE=4rk9W0E6pGOGRfA>