Date: Sat, 30 Nov 2019 11:25:07 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: Scott Long <scottl@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm Message-ID: <A3E9345E-9D69-445F-B9AC-29ED5E813860@gmail.com> In-Reply-To: <CANCZdfqS5D%2BNJsG-Chv9fFTxr1v-UexGBpb=mkp6vmL45a9m_w@mail.gmail.com> References: <201911280232.xAS2WHtb029602@repo.freebsd.org> <41D40355-A16E-48E1-9C11-0C9E42C83A42@gmail.com> <CANCZdfrLMH_RNdd-hQrzGymZ_gjUc6YuqtfJON4muruutNyNxA@mail.gmail.com> <F77D7E9F-E158-4325-9399-D26FFF88F583@gmail.com> <CANCZdfqS5D%2BNJsG-Chv9fFTxr1v-UexGBpb=mkp6vmL45a9m_w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Nov 30, 2019, at 11:01 AM, Warner Losh <imp@bsdimp.com> wrote: >=20 > On Sat, Nov 30, 2019 at 11:58 AM Enji Cooper <yaneurabeya@gmail.com = <mailto:yaneurabeya@gmail.com>> wrote: >=20 >> On Nov 30, 2019, at 10:03 AM, Warner Losh <imp@bsdimp.com = <mailto:imp@bsdimp.com>> wrote: >>=20 >>=20 >>=20 >> On Sat, Nov 30, 2019 at 10:47 AM Enji Cooper <yaneurabeya@gmail.com = <mailto:yaneurabeya@gmail.com>> wrote: >>=20 >> > On Nov 27, 2019, at 6:32 PM, Scott Long <scottl@FreeBSD.org = <mailto:scottl@FreeBSD.org>> wrote: >> >=20 >> > Author: scottl >> > Date: Thu Nov 28 02:32:17 2019 >> > New Revision: 355164 >> > URL: https://svnweb.freebsd.org/changeset/base/355164 = <https://svnweb.freebsd.org/changeset/base/355164>; >> >=20 >> > Log: >> > Remove the trm(4) driver >> >=20 >> > Differential Revision: https://reviews.freebsd.org/D22575 = <https://reviews.freebsd.org/D22575>; >>=20 >> Hi Scott, >> I believe this driver was removed because it was impacts the = CAM GIANT lock removal effort =E2=80=94 is that true (I=E2=80=99m asking = because the =E2=80=9Cwhy=E2=80=9D behind the removal is unclear)? >>=20 >> Hi Enji, >>=20 >> We're trying hard to get rid of all Giant-locked drivers in the tree, = either by updating or removal. Since sym(4) provides a super-set of = trm(4) and we have recent-ish reports of sym(4) working, it makes sense = to trim this driver from the tree. The specific cards it supports aren't = all that popular, the couple-extra features that trm(4) gave over sym(4) = aren't really that relevant today, and it's been years since trm has had = good testing and maintenance. >=20 > Warner, > Thanks so very much for the info :). Glad to see this effort = taking place, since it=E2=80=99s very needed to modernize FreeBSD and = improve concurrency in the kernel, as well as reduce the overall = maintenance burden. >=20 > Giant isn't contending, but it's getting in the way of a cleanup of = the console / kbd system, as well as there being newbus issues in highly = dynamic systems. With TB and USB4 support on the horizon, we need to = finally clean that mess up.. I'll post a longer summary of what's left. = I have a 'doodle' tree that I'm separating out the Giant usage to = 'driver lock', kbd/console/ddb, newbus, sysctl, and WTF is that = protecting... I'm tempted to create wtf_lock() and wtf_unlock(), but I'm = not sure how well that would go over :) Sounds great :D=E2=80=A6 -Enji PS wtf_lock() would be amusing, but probably less of a good idea these = days :D...=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A3E9345E-9D69-445F-B9AC-29ED5E813860>