Date: Sat, 27 Jan 2018 19:37:45 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Ian Lepore <ian@freebsd.org>, Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328486 - head/usr.bin/fortune/fortune Message-ID: <1ea5c2a1-c65c-09ef-558c-287657df4ba1@FreeBSD.org> In-Reply-To: <1517094539.1517.9.camel@freebsd.org> References: <201801271743.w0RHh9io022619@repo.freebsd.org> <CAG6CVpUOxtE9p8OApL6LsUJWh5tTM_9647M0qe5VNSnTTSEvQw@mail.gmail.com> <1f1eb186-8f7b-6ec9-0970-d8b82b909e7b@FreeBSD.org> <CAG6CVpXXUSPwUsxqXhJBfq_f-FwFAWXO4uQu4f2evWet90fBNg@mail.gmail.com> <1517094539.1517.9.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/27/18 18:08, Ian Lepore wrote: > On Sat, 2018-01-27 at 22:56 +0000, Conrad Meyer wrote: >> I don�t think dragonfly has anything to do with this?��If you�re >> converting >> bool increments to setting true values in FreeBSD, use >> �true.���That�s all >> there is to it. >> >> Best, >> Conrad > style(9) emphasizes internal consistancy in several places. �The > uppercase TRUE/FALSE is currently the style within that code, so it > makes sense to stick with it. �If a (somewhat gratuitous) conversion to > the new style is made, it should be a separate commit just for that, > emphasizing that it changes just style and not functionality. Indeed. I didn't want to mix FALSE with false and TRUE with true so I did the change as is to make the diff smaller and still have everything look consistent. Further cleanups (DragonFly already did it) should be done in a different commit. I personally don't feel it's something important though. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1ea5c2a1-c65c-09ef-558c-287657df4ba1>