Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Feb 2023 22:04:56 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        John-Mark Gurney <jmg@funkthat.com>, src-committers <src-committers@freebsd.org>,  "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org,  Warner Losh <imp@freebsd.org>
Subject:   Re: git: ee97f198b42d - main - Support SMBIOS v3 for 64-bit entry systems
Message-ID:  <CANCZdfrr6wJJokOj83A9Wispm%2BmuedMAayck=zNAnp74b-Knew@mail.gmail.com>
In-Reply-To: <20230222043708.GQ95670@funkthat.com>
References:  <202302220431.31M4VgwO065942@gitrepo.freebsd.org> <20230222043708.GQ95670@funkthat.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000000dae205f542d766
Content-Type: text/plain; charset="UTF-8"

On Tue, Feb 21, 2023, 9:37 PM John-Mark Gurney <jmg@funkthat.com> wrote:

> John-Mark Gurney wrote this message on Wed, Feb 22, 2023 at 04:31 +0000:
> > The branch main has been updated by jmg:
> >
> > URL:
> https://cgit.FreeBSD.org/src/commit/?id=ee97f198b42d50437f87aa4111d478eca2a5be16
> >
> > commit ee97f198b42d50437f87aa4111d478eca2a5be16
> > Author:     John-Mark Gurney <jmg@FreeBSD.org>
> > AuthorDate: 2023-02-22 02:27:37 +0000
> > Commit:     John-Mark Gurney <jmg@FreeBSD.org>
> > CommitDate: 2023-02-22 04:10:12 +0000
> >
> >     Support SMBIOS v3 for 64-bit entry systems
> >
> >     Summary:
> >     Under QEMU on arm64 systems, the smbios table is above 4GB
> >     requiring a 64-bit address to access.
> >
> >     Reviewers: manu
> >
> >     Subscribers: imp, bcran, dab
> >
> >     Differential Revision: https://reviews.freebsd.org/D38721
>
> Sorry, but this commit message is incorrect, it should be
> Reviewed by: imp
>
> and the Reviewers and subscriber lines dropped.
>
> I had editted the file, but due to wonkyness w/ git, that amended
> commit got lost and the original one was submitted instead.
>
> Not sure if there is a way to fix it though.
>

You can't fix it. But it's not a huge deal...

How'd you land this? with 'arc' or 'git arc' Since I've started using the
latter, I've not had issues... Raw 'arc' seems to have an extra layer of
wonkiness...

Warner

-- 
>   John-Mark Gurney                              Voice: +1 415 225 5579
>
>      "All that I will do, has been done, All that I have, has not."
>

--00000000000000dae205f542d766
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Tue, Feb 21, 2023, 9:37 PM John-Mark Gurney &lt;<a =
href=3D"mailto:jmg@funkthat.com">jmg@funkthat.com</a>&gt; wrote:<br></div><=
blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px=
 #ccc solid;padding-left:1ex">John-Mark Gurney wrote this message on Wed, F=
eb 22, 2023 at 04:31 +0000:<br>
&gt; The branch main has been updated by jmg:<br>
&gt; <br>
&gt; URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3Dee97f198b42d=
50437f87aa4111d478eca2a5be16" rel=3D"noreferrer noreferrer" target=3D"_blan=
k">https://cgit.FreeBSD.org/src/commit/?id=3Dee97f198b42d50437f87aa4111d478=
eca2a5be16</a><br>
&gt; <br>
&gt; commit ee97f198b42d50437f87aa4111d478eca2a5be16<br>
&gt; Author:=C2=A0 =C2=A0 =C2=A0John-Mark Gurney &lt;jmg@FreeBSD.org&gt;<br=
>
&gt; AuthorDate: 2023-02-22 02:27:37 +0000<br>
&gt; Commit:=C2=A0 =C2=A0 =C2=A0John-Mark Gurney &lt;jmg@FreeBSD.org&gt;<br=
>
&gt; CommitDate: 2023-02-22 04:10:12 +0000<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0Support SMBIOS v3 for 64-bit entry systems<br>
&gt;=C2=A0 =C2=A0 =C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0Summary:<br>
&gt;=C2=A0 =C2=A0 =C2=A0Under QEMU on arm64 systems, the smbios table is ab=
ove 4GB<br>
&gt;=C2=A0 =C2=A0 =C2=A0requiring a 64-bit address to access.<br>
&gt;=C2=A0 =C2=A0 =C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0Reviewers: manu<br>
&gt;=C2=A0 =C2=A0 =C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0Subscribers: imp, bcran, dab<br>
&gt;=C2=A0 =C2=A0 =C2=A0<br>
&gt;=C2=A0 =C2=A0 =C2=A0Differential Revision: <a href=3D"https://reviews.f=
reebsd.org/D38721" rel=3D"noreferrer noreferrer" target=3D"_blank">https://=
reviews.freebsd.org/D38721</a><br>
<br>
Sorry, but this commit message is incorrect, it should be<br>
Reviewed by: imp<br>
<br>
and the Reviewers and subscriber lines dropped.<br>
<br>
I had editted the file, but due to wonkyness w/ git, that amended<br>
commit got lost and the original one was submitted instead.<br>
<br>
Not sure if there is a way to fix it though.<br></blockquote></div></div><d=
iv dir=3D"auto"><br></div><div dir=3D"auto">You can&#39;t fix it. But it&#3=
9;s not a huge deal...</div><div dir=3D"auto"><br></div><div dir=3D"auto">H=
ow&#39;d you land this? with &#39;arc&#39; or &#39;git arc&#39; Since I&#39=
;ve started using the latter, I&#39;ve not had issues... Raw &#39;arc&#39; =
seems to have an extra layer of wonkiness...</div><div dir=3D"auto"><br></d=
iv><div dir=3D"auto">Warner</div><div dir=3D"auto"><br></div><div dir=3D"au=
to"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"m=
argin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
-- <br>
=C2=A0 John-Mark Gurney=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Voice: +1 415 225 5579=
<br>
<br>
=C2=A0 =C2=A0 =C2=A0&quot;All that I will do, has been done, All that I hav=
e, has not.&quot;<br>
</blockquote></div></div></div>

--00000000000000dae205f542d766--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrr6wJJokOj83A9Wispm%2BmuedMAayck=zNAnp74b-Knew>