Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 05 Jul 2016 14:46:19 -0600
From:      Ian Lepore <ian@freebsd.org>
To:        Adam Weinberger <adamw@adamw.org>, Christian Weisgerber <naddy@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r418108 - head/net/openntpd
Message-ID:  <1467751579.72182.101.camel@freebsd.org>
In-Reply-To: <CB8C1909-1D3F-4A18-819C-9109AEE2EC02@adamw.org>
References:  <201607051932.u65JWH1S024239@repo.freebsd.org> <CB8C1909-1D3F-4A18-819C-9109AEE2EC02@adamw.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2016-07-05 at 13:37 -0600, Adam Weinberger wrote:
> > On 5 Jul, 2016, at 13:32, Christian Weisgerber <naddy@FreeBSD.org>
> > wrote:
> > 
> > Author: naddy
> > Date: Tue Jul  5 19:32:17 2016
> > New Revision: 418108
> > URL: https://svnweb.freebsd.org/changeset/ports/418108
> > 
> > Log:
> >  Minor changes/improvements:
> >  * switch to USES=ssl
> >  * use the paths set by Mk/Uses/ssl.mk
> >  * move post-install to post-stage
> > 
> >  Submitted by:	brnrd
> > 
> > Modified:
> >  head/net/openntpd/Makefile
> > 
> > Modified: head/net/openntpd/Makefile
> > ===================================================================
> > ===========
> > --- head/net/openntpd/Makefile	Tue Jul  5 19:31:56 2016	
> > (r418107)
> > +++ head/net/openntpd/Makefile	Tue Jul  5 19:32:17 2016	
> > (r418108)
> > @@ -26,18 +26,17 @@ RESSL_DESC=		SSL/TLS support via
> > LibreSS
> > OPTIONS_DEFAULT=	RESSL
> > 
> > # Requires libtls from LibreSSL
> > -RESSL_USE=		openssl=yes
> > -RESSL_VARS=		with_openssl_port=yes
> > +RESSL_USES=		ssl
> > RESSL_CONFIGURE_WITH=	cacert=${LOCALBASE}/etc/ssl/cert.pem
> > -RESSL_CPPFLAGS=		-I${LOCALBASE}/include
> > -RESSL_LDFLAGS=		-L${LOCALBASE}/lib
> > +RESSL_CPPFLAGS=		-I${OPENSSLINC}
> > +RESSL_LDFLAGS=		-L${OPENSSLLIB}
> 
> OPENSSLINC/LIB doesn˙t necessarily contain anything before
> bsd.port.pre.mk. I think you want to assign these farther down.
> 
> # Adam
> 

That doesn't matter.  The value of a make variable is expanded late,
either when it's used in a rule, or in a .if/.for, or assigned to
another variable using :=.

In the cases above, what gets assigned to, e.g., RESSL_CPPFLAGS is
literally the characters '-I${OPENSSLINC}', not -I followed by the
expansion of the OPENSSLINC variable.

-- Ian




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1467751579.72182.101.camel>