Date: Tue, 3 Feb 2004 22:45:30 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: freebsd-arch@freebsd.org Subject: Non-standard ;; and SYSINIT(). Message-ID: <20040203214530.GB14639@garage.freebsd.pl>
next in thread | raw e-mail | index | archive | help
--0eh6TmSyL6TZE2Uz Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello. It looks like SYSINIT() macro is defined with trailing ;. Maybe there was some reason to do so, but I assume that this is a bug. There are many, many calls where an extra ; is added after SYSINIT(). SYSUNINIT() is defined without trailing ; ... This will be ok, but ;; is not supported by ICO C (gcc -pedantic tell me that). Here is a patch that fix this issue at least for SYSINIT(): http://garage.freebsd.pl/patches/SYSINIT.patch The most important part is a change in sys/kernel.h, that removes trailing ; from SYSINIT() definition: - DATA_SET(sysinit_set,uniquifier ## _sys_init); + DATA_SET(sysinit_set,uniquifier ## _sys_init) AND REMEMBER! I'm not going to commit it (without strong approvals)!:) --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --0eh6TmSyL6TZE2Uz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQFAIBZ6ForvXbEpPzQRAsN7AKDrvbOnySBlqZVk6OOOG6iOeF4FnQCfRtwj CElZwVYZIqj0PAc+CrzKfA4= =VOMk -----END PGP SIGNATURE----- --0eh6TmSyL6TZE2Uz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040203214530.GB14639>