Date: Sun, 22 Oct 2000 05:07:28 -0700 (PDT) From: Dag-Erling Smorgrav <des@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/lib/libfetch ftp.c Message-ID: <200010221207.FAA77931@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
des 2000/10/22 05:07:28 PDT
Modified files:
lib/libfetch ftp.c
Log:
Use funopen() instead of fdopen(). This fixes three problems:
- ftpTimeout was not honored when reading actual data, as opposed to
talking protocol
- connection caching was broken because _ftp_cached_connect() would see
the result of the transfer instead of the result of the NOOP.
- if the RETR succeeded, but an error occurred later (as can happen
when talking to a proxy), the error would not be detected.
There still remains to register an atexit(3) callback to close the cached
connection gracefully instead of just dropping it on the floor.
Revision Changes Path
1.45 +119 -5 src/lib/libfetch/ftp.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010221207.FAA77931>