Date: Wed, 01 May 2002 23:57:39 +0000 From: Dima Dorfman <dima@trit.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kmod.mk Message-ID: <20020501235744.ACE123F71@turbine.trit.org> In-Reply-To: <200205011924.g41JOQJ55987@freefall.freebsd.org>; from imp@FreeBSD.org on "Wed, 1 May 2002 12:24:26 -0700 (PDT)"
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh <imp@FreeBSD.org> wrote:
> Log:
> We don't need no stinkin' echos here.
...
> Index: src/sys/conf/kmod.mk
> diff -u src/sys/conf/kmod.mk:1.122 src/sys/conf/kmod.mk:1.123
> --- src/sys/conf/kmod.mk:1.122 Tue Apr 30 20:28:14 2002
> +++ src/sys/conf/kmod.mk Wed May 1 12:24:26 2002
> @@ -170,6 +170,9 @@
> .endif
> .endif
>
> +.if !exists(/usr/sbin/kldxref)
> +NO_XREF=yes
> +.endif
>
> _ILINKS=@ machine
>
> @@ -257,9 +260,7 @@
> done; true
> .endif
> .if !defined(NO_XREF)
> - @echo "FAILURES HERE ARE OK"
> -kldxref ${DESTDIR}${KMODDIR}
Since we don't get here when kldxref doesn't exist any more, shouldn't
we get rid of the '-'? I.e., make the last line read:
kldxref ${DESTDIR}${KMODDIR}
Or are their other failure modes we want to ignore?
> - @echo "END OF SECTION WHERE FAILURES ARE OK"
> .endif
> .endif
>
> @@ -345,5 +346,4 @@
> .endif
>
> .include <bsd.obj.mk>
> -
> .include <bsd.kern.mk>
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020501235744.ACE123F71>