Date: Tue, 29 Apr 2014 16:53:29 +0400 From: "Alexander V. Chernikov" <melifaro@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r264986 - head/sys/net Message-ID: <535FA0C9.3060308@FreeBSD.org> In-Reply-To: <20140428085941.GW85571@FreeBSD.org> References: <201404262103.s3QL3fAX048245@svn.freebsd.org> <20140428085941.GW85571@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28.04.2014 12:59, Gleb Smirnoff wrote:
> On Sat, Apr 26, 2014 at 09:03:41PM +0000, Alexander V. Chernikov wrote:
> A> @@ -1425,6 +1431,95 @@ bad:
> A> #undef ifpaddr
> A> #undef flags
> A>
> A> +#define senderr(e) { error = e; goto bad; }
>
> ...
>
> A> + if (error != 0)
> A> + senderr(error);
>
> This resolves to "error = error". Surprised that compiler is silent.
>
> Can this line and others like it be replaced with?
Yup. done in r265091.
> if (error)
> goto bad;
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?535FA0C9.3060308>