Date: Thu, 28 Jul 2016 15:59:20 +0000 From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: "Christian Mauderer" <christian.mauderer@embedded-brains.de> Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: Re: Changes to pfctl to allow easier integration into a library Message-ID: <B2EA8BF5-115F-48D0-9561-68D3AE4642CD@lists.zabbadoz.net> In-Reply-To: <25df9fd5-be75-b9ae-aa3a-22abef3bddf0@embedded-brains.de> References: <25df9fd5-be75-b9ae-aa3a-22abef3bddf0@embedded-brains.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28 Jul 2016, at 14:03, Christian Mauderer wrote: > Hello, > > I'm currently working on a porting pfctl to a real-time operating > system. This is done using the same framework that Sebastian Huber > mentioned here (and probably at some other occasions): > … > Would the attached patches be acceptable for integration into the > FreeBSD sources? Hi, (a) I’d prefer uintX_t to u_intX_t and I think FreeBSD is using the former generally. (b) All the variables you pulled out of functions that are not const, would need to be virtualised for VIMAGE, as otherwise one virtual network stack could affect another. Would you be willing to look into this? Gruesse /bz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B2EA8BF5-115F-48D0-9561-68D3AE4642CD>