Date: Thu, 17 Nov 2016 20:23:28 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Ngie Cooper <yaneurabeya@gmail.com> Cc: Mark Johnston <markj@freebsd.org>, Sepherosa Ziehau <sephe@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r308664 - in head: contrib/hyperv/tools etc/devd etc/mtree include share/man/man4 sys/conf sys/dev/hyperv/utilities sys/modules/hyperv/utilities usr.sbin/hyperv usr.sbin/hyperv/tools us... Message-ID: <EF681512-715E-4830-AC3B-F97D8180A9F1@FreeBSD.org> In-Reply-To: <CAGHfRMB8U2X0aAqi-zd4tZV2zd4OhH%2B_7sU1dcQTXsmkBapNKA@mail.gmail.com> References: <201611150236.uAF2aCV8015106@repo.freebsd.org> <20161116221440.GA83880@wkstn-mjohnston.west.isilon.com> <CAGHfRMB8U2X0aAqi-zd4tZV2zd4OhH%2B_7sU1dcQTXsmkBapNKA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_298B0D63-2035-422A-B34B-C42275DE7318 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 17 Nov 2016, at 01:31, Ngie Cooper <yaneurabeya@gmail.com> wrote: > > On Wed, Nov 16, 2016 at 2:14 PM, Mark Johnston <markj@freebsd.org> wrote: > ... >> This appears to install hv_kvp_daemon and hv_vss_daemon to / instead of >> /usr/sbin, and breaks the -DNO_ROOT build. I think a Makefile.inc is >> needed in usr.sbin/hyperv/tools in order to preserve BINDIR from >> usr.sbin/Makefile.inc. I fixed the problem in my tree with the diff >> below, but am not sure if this is the right way to do it. For some >> reason, doing this resulted in unused var warnings compiling >> hv_vss_daemon.c. > > The -Wunused warnings you're seeing are because you're now it's > setting WARNS by .include'ing usr.bin/Makefile.inc ; it used to be set > (I verified that), but then got unset between a few weeks ago and now > on the directory: > > $ make -V.CURDIR -VWARNS > /usr/src/usr.sbin/hyperv/tools > > $ > > Cheers, > -Ngie > > PS -Wno-uninitialized is only set for gcc...? Really...??? Yes, because base gcc has produced many false positives with its -Wuninitialized warnings. In fact, I would suggest that is globally turned off for any gcc version before 4.7. -Dimitry --Apple-Mail=_298B0D63-2035-422A-B34B-C42275DE7318 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlguA78ACgkQsF6jCi4glqPt9ACg4ZUbfFmnLfKJechINmWtv+e6 UNgAoLcZU5VebYLSWZpenkyjaz4ED7fm =wfLC -----END PGP SIGNATURE----- --Apple-Mail=_298B0D63-2035-422A-B34B-C42275DE7318--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EF681512-715E-4830-AC3B-F97D8180A9F1>