Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Apr 2002 19:54:30 -0800
From:      Alfred Perlstein <bright@mu.org>
To:        Jon Ringuette <wintermute@imeme.net>
Cc:        freebsd-hackers@freebsd.org
Subject:   Re: Question about possibly additions to TOP
Message-ID:  <20020402035430.GE93885@elvis.mu.org>
In-Reply-To: <3CA92355.8050001@imeme.net>
References:  <3CA92355.8050001@imeme.net>

next in thread | previous in thread | raw e-mail | index | archive | help
* Jon Ringuette <wintermute@imeme.net> [020401 19:20] wrote:
> Sorry to bother everyone here but I have a quick question (or I guess 
> what I hope is a quick question).  I have made some modifications to 
> src/usr.bin/machine.c to allow TOP to run in a jail (I have mostly just 
> taken out kvm_read's ) and zero'd out alot of information that is not 
> available to TOP in a jail  ie . Total memory usage / swap usage / cpu 
> usage etc..  I would like to add an option -j to top and have it check 
> for that option to do this (sort of a really lightweight top if this 
> option is used).  Would this be of interest to anymore for me to submit 
> a patch and if so how should I go about adding the -j option should I 
> make a copy of the top.c into src/usr.bin/top or contact the auther of 
> top to see about submitting it to him?  I'm not sure if this would be 
> useful to anyone outside of the FreeBSD community is the reason I am a 
> bit iffy about doing that.  If someone could point me in the right 
> direction to do this the correct way I would be very grateful, I really 
> want to code but I'm not sure where and how i should do it :)

That would be pretty cool, why don't you use the gnats:
http://www.freebsd.org/send-pr.html
or just "send-pr"

to submit your changes?

One idea would be to fail gracefully, when unable to read kvm and
such and keep the -j flag idea you had.

-Alfred

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020402035430.GE93885>