Date: Mon, 2 Jun 2008 09:53:15 +0200 From: Roman Divacky <rdivacky@FreeBSD.org> To: Ed Schouten <ed@80386.nl> Cc: freebsd-emulation@FreeBSD.org, philip@FreeBSD.org Subject: Re: Linux major/minor conversion not entirely correct Message-ID: <20080602075315.GB67510@freebsd.org> In-Reply-To: <20080602073152.GO64397@hoeg.nl>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Jun 02, 2008 at 09:31:52AM +0200, Ed Schouten wrote: > Hello everyone, > > The last couple of months I've been working on redesigning FreeBSD's TTY > layer. This is all going quite good. Too good, actually. > > Last week I've been toying around with getting sshd working inside a > Linux jail, which seems to work quite nicely right now. I've made some > changes to our Linux compat layer that could already get (partially) > merged back to SVN. > > The Linux compat layer generates fake major/minor numbers for certain > devices, because Linux still depends on that information a lot (yuck). > I've discovered that our Linux compat layer returns the same major/minor > pair for all nodes in /dev/pts, but doesn't do this consistently either. > We'd better push the conversion down into linux_driver_get_major_minor(), > to make sure the numbers always get converted. We should also make sure > we hand out unique numbers. > > The patch also contains a change I made to support the new DTYPE_PTS > (pseudo-terminal master device). This part of the diff should be > ignored. I've just added it for completeness. > > Does anyone mind if I commit this patch soonish? I dont see a problem with it... go commit that. thnx! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkhDpusACgkQLVEj6D3CBExamwCfZrps5Gv8JBvg8KjvsB/GjrRb gv4AniCY4xC1c+BLqq91Lby99FL/mBmU =K5nh -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080602075315.GB67510>