Date: Tue, 4 Oct 2022 21:16:54 -0400 From: Ed Maste <emaste@freebsd.org> To: Hans Petter Selasky <hselasky@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d97ecf714e79 - main - time(3): Increase precision of time conversion functions by using gcd. Message-ID: <CAPyFy2CZe%2Bdi9QshjauPzw_6==rQZRGyDVqicTSt9pCp86BgBQ@mail.gmail.com> In-Reply-To: <bda553c7-de66-8797-fb14-78dd91e708a2@freebsd.org> References: <202210041153.294Br4Si011556@gitrepo.freebsd.org> <bb67f80f-c723-18bc-a0a9-3335baf54731@FreeBSD.org> <bda553c7-de66-8797-fb14-78dd91e708a2@freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Tue, 4 Oct 2022 at 15:53, Hans Petter Selasky <hselasky@freebsd.org> wrote: > > On 10/4/22 18:41, John Baldwin wrote: > > > > For future reference: Phab only auto-closes a review if the Differential > > Revision > > tag is the last tag in the commit log. This is why it is listed last in > > the > > commit log template. > > > > I'm a little confused. My phab review did auto close?? Yeah, I think it's actually that "Differential Revision" has to be in the last paragraph (i.e., no blank lines following it). Perhaps this changed with some Phabricator update, as I believe it had to be the last line at one point. Either way by convention it should be the last line.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CZe%2Bdi9QshjauPzw_6==rQZRGyDVqicTSt9pCp86BgBQ>