Date: Sat, 21 Oct 2006 14:24:44 +0400 (MSD) From: Yuriy Tsibizov <Yuriy.Tsibizov@gfk.ru> To: John-Mark Gurney <jmg@FreeBSD.org>, Yuriy Tsibizov <Yuriy.Tsibizov@gfk.ru> Cc: cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pci pci.c Message-ID: <20061021142416.G1198@free.home.local> In-Reply-To: <200610202128.k9KLSBgo059305@repoman.freebsd.org> References: <200610202128.k9KLSBgo059305@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> jmg 2006-10-20 21:28:11 UTC > > FreeBSD src repository > > Modified files: > sys/dev/pci pci.c > Log: > fix tab indentation for CP and RV... > > If the length is zero, catch this early, instead of making dflen go negative > and letting bad things happen... We also check to see if RV (checksum) is > 0, and handle that has a checksum failure... > > Properly handle checksum failures by not processing read-write VPD data, > and removing all the found read-only data... > > Tested by: oleg (dflen going negative) John-Mark, what 'bad things' will not happen? I see that commited patch differs from one you posted earlier on cvs-src which (possibly) caused my Realtek PCIE network card to change it's PCI id (as described in message to -current, under 'RE:ASUS U5F hangs during PCI bus probe' subject). Are there any possibility to check arguments of pci_read_vpd_reg to make shure it will write only in correct PCI configuration register? Yuriy. p.s. Please keep me in to/cc, I'm currently off-list.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061021142416.G1198>