Date: Wed, 13 Nov 2002 18:48:04 -0800 From: Luigi Rizzo <rizzo@icir.org> To: Maxim Konovalov <maxim@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c Message-ID: <20021113184804.A73212@xorpc.icir.org> In-Reply-To: <200211131131.gADBViEe010812@repoman.freebsd.org>; from maxim@FreeBSD.ORG on Wed, Nov 13, 2002 at 03:31:44AM -0800 References: <200211131131.gADBViEe010812@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
i'd actually shorten the MFC to 3 days because this is a fix for a bug that i introduced around last june (in fact the bug has always been there, but did not harm because in the past the struct ipfw_flow_id was static and so the extra bytes were not dirtied by whatever was on the stack). cheers luigi On Wed, Nov 13, 2002 at 03:31:44AM -0800, Maxim Konovalov wrote: > maxim 2002/11/13 03:31:44 PST > > Modified files: > sys/netinet ip_dummynet.c > Log: > Due to a memory alignment sizeof(struct ipfw_flow_id) is bigger than > ipfw_flow_id structure actual size and bcmp(3) may fail to compare > them properly. Compare members of these structures instead. > > PR: kern/44078 > Submitted by: Oleg Bulyzhin <oleg@rinet.ru> > Reviewed by: luigi > MFC after: 2 weeks > > Revision Changes Path > 1.55 +6 -1 src/sys/netinet/ip_dummynet.c > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-all" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021113184804.A73212>