Date: Fri, 30 Dec 2011 20:41:25 +0000 (UTC) From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r229024 - head/lib/libc/gen Message-ID: <201112302041.pBUKfP2v029586@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dim Date: Fri Dec 30 20:41:24 2011 New Revision: 229024 URL: http://svn.freebsd.org/changeset/base/229024 Log: Add some additional const poison after r228972. The 'mapping' array in lib/libc/gen/strtofflags.c became const, but gcc did not warn about assigning its members to non-const pointers. Clang warned about this with: lib/libc/gen/strtofflags.c:98:12: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types] for (sp = mapping[i].invert ? mapping[i].name : ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reviewed by: jilles Modified: head/lib/libc/gen/strtofflags.c Modified: head/lib/libc/gen/strtofflags.c ============================================================================== --- head/lib/libc/gen/strtofflags.c Fri Dec 30 20:35:13 2011 (r229023) +++ head/lib/libc/gen/strtofflags.c Fri Dec 30 20:41:24 2011 (r229024) @@ -82,7 +82,8 @@ fflagstostr(flags) u_long flags; { char *string; - char *sp, *dp; + const char *sp; + char *dp; u_long setflags; int i;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112302041.pBUKfP2v029586>