Date: Wed, 16 Apr 2003 16:11:24 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: John Hay <jhay@icomtek.csir.co.za> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/wl if_wl.c Message-ID: <XFMail.20030416161124.jhb@FreeBSD.org> In-Reply-To: <20030416183846.GA41630@zibbi.icomtek.csir.co.za>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16-Apr-2003 John Hay wrote: > On Wed, Apr 16, 2003 at 02:06:25PM -0400, John Baldwin wrote: >> >> On 16-Apr-2003 John Hay wrote: >> > jhay 2003/04/16 10:42:38 PDT >> > >> > FreeBSD src repository >> > >> > Modified files: >> > sys/dev/wl if_wl.c >> > Log: >> > Add locking and remove all the spl() calls. >> >> Note that some of the spl calls covered structures other than >> just the softc. I'd prefer that we leave spl calls in until >> all the structures they cover are locked. > > Ok, should I put them all back? Or just the ones being used as > interrupt disablers? And what about the places where there > should have been splx()es but weren't? I would put back any spl's covering things not covered by the locks you added. :) Adding in missing spl's is not necessarily required, so doing or not doing that is your choice. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030416161124.jhb>