Date: Thu, 30 Aug 2001 13:39:41 -0700 (PDT) From: Matthew Jacob <mjacob@feral.com> To: =?ISO-8859-1?Q?G=E9rard_Roudier?= <groudier@free.fr> Cc: <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/cam/scsi scsi_sa.c Message-ID: <20010830133414.T85192-100000@wonky.feral.com> In-Reply-To: <20010830212344.A1692-100000@gerard>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 30 Aug 2001, [ISO-8859-1] Gérard Roudier wrote: > > > On Thu, 30 Aug 2001, Matt Jacob wrote: > > [...] > > > 2. If we get a Bus Reset, had a BDR sent, or get the cam status of > > CAM_REQUEUE_REQ, check the retry count on the command. The default > > error handler, cam_periph_error, doesn't honor retry count in these > > cases. This may change in the future, but for now, make sure we > > set EIO and return without calling cam_periph_error if the retry > > count for the command with an error is zero. > > You certainly didn't miss that commands returned by SIMs with > CAM_REQUEUE_REQ status haven't ever being tried. Checking against the > retry count for these ones does not make sense, in my opinion. Umm- you're probably right for CAM_REQUEUE_REQ. > > The retry could should only be counted for the command that failed and > that made the SIM ask for some other commands to be requeued, in my humble > :) opinion. Not sure I follow this. > > It may well be very unlikely and probably just bogus for a batch of > commands to be completed with CAM_REQUEUE_REQ and not even a single > command being completed with a true failure condition (for a given > device). Yes. -matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010830133414.T85192-100000>