Date: Wed, 06 Nov 2002 17:08:23 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Hidetoshi Shimokawa <simokawa@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/nge if_nge.c if_ngereg.h Message-ID: <2604.1036598903@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 06 Nov 2002 07:50:32 PST." <200211061550.gA6FoWQj062987@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200211061550.gA6FoWQj062987@repoman.freebsd.org>, Hidetoshi Shimoka wa writes: >simokawa 2002/11/06 07:50:32 PST > > Modified files: > sys/dev/nge if_nge.c if_ngereg.h > Log: > Add support for DEVICE_POLLING. > > PR: kern/44772 > Submitted by: Takashi Oono <takashi@yha.att.ne.jp> > MFC after: 1 week > > Revision Changes Path > 1.36 +76 -0 src/sys/dev/nge/if_nge.c > 1.8 +3 -0 src/sys/dev/nge/if_ngereg.h Hang on for a second: This chip supports interrupt pacing so I would like to see some documentation for an improvement from DEVICE_POLLING over tuning the interrupt pacing in the chip, before we even think about MFC, much less let this commit stay in the tree. What tests have been run ? What are the numbers ? (and please, include a standard deviation!) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2604.1036598903>