Date: Thu, 5 May 2011 15:12:43 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Andrey V. Elsukov" <ae@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221449 - head/sys/geom/journal Message-ID: <20110505131242.GC14661@garage.freebsd.pl> In-Reply-To: <201105041806.p44I6edT061463@svn.freebsd.org> References: <201105041806.p44I6edT061463@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, May 04, 2011 at 06:06:40PM +0000, Andrey V. Elsukov wrote: > Author: ae > Date: Wed May 4 18:06:40 2011 > New Revision: 221449 > URL: http://svn.freebsd.org/changeset/base/221449 > > Log: > Removed KASSERT, g_new_providerf() can not fail. Well, the assertion was there to prepare us for times when g_new_providerf() will be able to fail. I was suspecting we might want to make g_new_providerf() to fail when the given name is already in use. In such case we use to create two identical entries in /dev/, not sure what we do now (panic?). > Modified: > head/sys/geom/journal/g_journal.c > > Modified: head/sys/geom/journal/g_journal.c > ============================================================================== > --- head/sys/geom/journal/g_journal.c Wed May 4 17:58:15 2011 (r221448) > +++ head/sys/geom/journal/g_journal.c Wed May 4 18:06:40 2011 (r221449) > @@ -2097,7 +2097,6 @@ g_journal_worker(void *arg) > gp = sc->sc_geom; > g_topology_lock(); > pp = g_new_providerf(gp, "%s.journal", sc->sc_name); > - KASSERT(pp != NULL, ("Cannot create %s.journal.", sc->sc_name)); > pp->mediasize = sc->sc_mediasize; > /* > * There could be a problem when data provider and journal providers -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk3CokoACgkQForvXbEpPzT5ogCfWqb2IW6BXrsddEg9DjDZzapA bGkAnjZiOhJL4t2TWFyS39p0NGOZfW/h =B+bh -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110505131242.GC14661>