Date: Wed, 16 Dec 2009 15:01:37 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: dougb@FreeBSD.org, freebsd-rc@FreeBSD.org Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-8@FreeBSD.org Subject: Re: svn commit: r200205 - stable/8/etc Message-ID: <20091216.150137.11277993.hrs@allbsd.org> In-Reply-To: <4B28181B.5070503@FreeBSD.org> References: <200912070625.nB76PJli043796@svn.freebsd.org> <4B28181B.5070503@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Wed_Dec_16_15_01_37_2009_122)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Doug Barton <dougb@FreeBSD.org> wrote in <4B28181B.5070503@FreeBSD.org>: do> You apparently merged your change from r197144 without applying my fix do> for this problem above from r198162, which broke this feature in do> 8-stable. See http://www.freebsd.org/cgi/query-pr.cgi?pr=141642 do> do> In my mind breaking this feature in a -stable branch is a fairly do> serious error, and adds fuel to my growing discomfort about the do> changes you've been making in /etc. How do you suggest that we move do> forward and at the same time lessen the potential for further problems? I am really sorry for breaking it again. My intention was to merge only changes of set_rcvar* on a request, but I mistakenly included the line you fixed after I committed the original change. It is totally my fault. Sorry. I think I will add regression tests for checking rc.d functionality before merging other changes I made on -HEAD. The rc.d scripts are used in various ways now and there are some ambiguous definitions and inconsistency such as a way to set the default value to a variable, naming conventions, and so on, so for that we may need to define what are correct/acceptable ones. Anyway, I start trying to do so and this should help to prevent further inappropriate changes (in terms of whether the existing functionality is broken or not) from being added. -- Hiroki ----Security_Multipart(Wed_Dec_16_15_01_37_2009_122)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAksod8EACgkQTyzT2CeTzy3ZTQCdGcpJ/K8xEN2eRsWjYC6hrqh8 okYAn3uzvbOCwS85lwRq18+AZLsnhitO =j2E6 -----END PGP SIGNATURE----- ----Security_Multipart(Wed_Dec_16_15_01_37_2009_122)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091216.150137.11277993.hrs>