Date: Thu, 5 Aug 2021 20:52:22 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Andrew Gallatin <gallatin@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2694c869ff9f - main - ktls: fix a panic with INVARIANTS Message-ID: <bb50b410-f01b-efbc-89d9-560e94161bce@selasky.org> In-Reply-To: <b4ae5fcf-31d3-6864-8df0-a468fd58f637@selasky.org> References: <202108051710.175HAP1D031061@gitrepo.freebsd.org> <b4ae5fcf-31d3-6864-8df0-a468fd58f637@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/5/21 8:49 PM, Hans Petter Selasky wrote:
> On 8/5/21 7:10 PM, Andrew Gallatin wrote:
>> + tsleep_sbt(sc, PZERO, "waiting for work", SBT_MAX, SBT_1S, 0);
>
> Hi,
>
> This basically puts a useless callout into the timer subsystem forever.
> I think if you don't care about this tsleep being accurate, then lock
> Giant and use sbt = 0.
>
> In between, I think that assert in question should be updated.
>
> --HPS
Or update the code:
if (sbt != 0)
sleepq_set_timeout_sbt(ident, sbt, pr, flags);
Should maybe be:
if (sbt > 0 && sbt < SBT_MAX)
sleepq_set_timeout_sbt(ident, sbt, pr, flags);
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb50b410-f01b-efbc-89d9-560e94161bce>