Date: Thu, 9 Aug 2012 19:48:47 GMT From: "A.J. Kehoe IV (Nanoman)" <g5ypsazo@nanoman.ca> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/170517: [patch] Correct audio/jack Dependency Declaration Message-ID: <201208091948.q79Jmllb036010@red.freebsd.org> Resent-Message-ID: <201208091950.q79Jo4PO025103@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 170517 >Category: ports >Synopsis: [patch] Correct audio/jack Dependency Declaration >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Aug 09 19:50:04 UTC 2012 >Closed-Date: >Last-Modified: >Originator: A.J. Kehoe IV (Nanoman) >Release: 9.0 >Organization: Nanoman's Company >Environment: FreeBSD localhost 9.0-RELEASE-p3 FreeBSD 9.0-RELEASE-p3 #0: Tue Jun 12 02:52:29 UTC 2012 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 >Description: The FreeBSD port audio/jack uses automatic detection to declare an optional dependency. This causes problems for port and package management. >How-To-Repeat: >Fix: I've attached a patch that corrects this by using the method suggested in the FreeBSD Porter's Handbook on the "Dependencies" page under "Problems Caused by Automatic Dependencies": http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html Patch attached with submission follows: --- ports/audio/jack/Makefile.old 2012-05-30 07:27:09.000000000 -0400 +++ ports/audio/jack/Makefile 2012-08-09 15:47:04.868404000 -0400 @@ -35,7 +35,8 @@ MAN1= jackd.1 jackstart.1 -OPTIONS_DEFINE= ALSA DOCS +OPTIONS_DEFINE= ALSA DOCS READLINE +READLINE_DESC= Enable Readline support .include <bsd.port.pre.mk> @@ -47,7 +48,7 @@ PLIST_SUB+= DOCS="@comment " .endif -.if exists(${LOCALBASE}/lib/libreadline.so.6) +.if ${PORT_OPTIONS:MREADLINE} LIB_DEPENDS+= readline.6:${PORTSDIR}/devel/readline .endif >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208091948.q79Jmllb036010>