Date: Tue, 10 Nov 2015 10:03:28 -0500 From: Randall Stewart <rrs@netflix.com> To: Hans Petter Selasky <hps@selasky.org> Cc: Randall Ray Stewart <rrs@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys Message-ID: <19671573-5C8C-4E33-845B-791DA966E4A9@netflix.com> In-Reply-To: <56420634.5060704@selasky.org> References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <56420634.5060704@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
And I disagree here Hans You don’t need that and it just adds more into the callout system that is not needed. R On Nov 10, 2015, at 9:59 AM, Hans Petter Selasky <hps@selasky.org> wrote: > On 11/10/15 15:49, Randall Stewart wrote: >> +#define callout_async_drain(c, d) \ >> + _callout_stop_safe(c, 0, d) > > Hi, > > Like commented in D4076, I think the callout_async_drain() function should take a second void pointer argument, which is passed to the drain function, instead of re-using the pointer argument passed to callout_reset(), because that will make many to one, N:1, asynchronous drain possible. > > --HPS -------- Randall Stewart rrs@netflix.com 803-317-4952
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19671573-5C8C-4E33-845B-791DA966E4A9>