Date: Fri, 01 Nov 2024 18:34:42 -0700 From: Ravi Pokala <rpokala@freebsd.org> To: Colin Percival <cperciva@FreeBSD.org>, <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org> Subject: Re: 6540ac118473 - main - modules: gpioaei only on ACPI-supporting archs Message-ID: <6E1A6F2E-C236-4A23-BFD2-8D917A02D5C2@panasas.com> In-Reply-To: <202410312247.49VMl6TW031342@gitrepo.freebsd.org> References: <202410312247.49VMl6TW031342@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Colin,
This seems to have broken arm64.LINT-FDT:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
% less _.arm64.LINT-FDT
...
--------------------------------------------------------------
>>> stage 3.1: building everything
--------------------------------------------------------------
In file included from /usr/home/rpokala/freebsd/src/clean-main/sys/dev/gpio=
//gpioaei.c:37:
/usr/home/rpokala/freebsd/src/clean-main/sys/dev/acpica/acpivar.h:34:10: fa=
tal error: 'acpi_if.h' file not found
34 | #include "acpi_if.h"
| ^~~~~~~~~~~
1 error generated.
*** [gpioaei.o] Error code 1
make[8]: stopped making "all" in /usr/home/rpokala/freebsd/src/clean-main/s=
ys/modules/gpio/gpioaei
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
-Ravi (rpokala@)
=EF=BB=BF-----Original Message-----
From: <owner-src-committers@freebsd.org <mailto:owner-src-committers@freebs=
d.org>> on behalf of Colin Percival <cperciva@FreeBSD.org <mailto:cperciva@F=
reeBSD.org>>
Date: Thursday, October 31, 2024 at 15:47
To: <src-committers@FreeBSD.org <mailto:src-committers@FreeBSD.org>>, <dev-=
commits-src-all@FreeBSD.org <mailto:dev-commits-src-all@FreeBSD.org>>, <dev-=
commits-src-main@FreeBSD.org <mailto:dev-commits-src-main@FreeBSD.org>>
Subject: git: 6540ac118473 - main - modules: gpioaei only on ACPI-supportin=
g archs
The branch main has been updated by cperciva:
URL: https://cgit.FreeBSD.org/src/commit/?id=3D6540ac118473dde29cb02f786c79c6=
4f73834ca1 <https://cgit.FreeBSD.org/src/commit/?id=3D6540ac118473dde29cb02f78=
6c79c64f73834ca1>
commit 6540ac118473dde29cb02f786c79c64f73834ca1
Author: Colin Percival <cperciva@FreeBSD.org <mailto:cperciva@FreeBSD.org>>
AuthorDate: 2024-10-31 22:45:03 +0000
Commit: Colin Percival <cperciva@FreeBSD.org <mailto:cperciva@FreeBSD.org>>
CommitDate: 2024-10-31 22:45:03 +0000
modules: gpioaei only on ACPI-supporting archs
Fixes: 9709bda03cd0 ("GPIO: Add ACPI _AEI support")
Pointy-hat to: cperciva
Sponsored by: Amazon
---
sys/modules/gpio/Makefile | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/sys/modules/gpio/Makefile b/sys/modules/gpio/Makefile
index 1d7f69f1836d..66090b1393bf 100644
--- a/sys/modules/gpio/Makefile
+++ b/sys/modules/gpio/Makefile
@@ -24,10 +24,14 @@
# SUCH DAMAGE.
#
-SUBDIR =3D gpioaei gpiobus gpioiic gpioled gpiospi gpioths
+SUBDIR =3D gpiobus gpioiic gpioled gpiospi gpioths
.if !empty(OPT_FDT)
SUBDIR +=3D gpiokeys gpiopps
.endif
+.if ${MACHINE_CPUARCH} =3D=3D "aarch64" || ${MACHINE_CPUARCH} =3D=3D "amd64" || ${=
MACHINE_CPUARCH} =3D=3D "i386"
+SUBDIR +=3D gpioaei
+.endif
+
.include <bsd.subdir.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6E1A6F2E-C236-4A23-BFD2-8D917A02D5C2>