Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 20 Oct 2002 17:35:12 +0200
From:      Dag-Erling Smorgrav <des@ofug.org>
To:        Alfred Perlstein <alfred@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libfetch common.c
Message-ID:  <xzpy98tw2bz.fsf@flood.ping.uio.no>
In-Reply-To: <200209202150.g8KLov9s006373@freefall.freebsd.org> (Alfred Perlstein's message of "Fri, 20 Sep 2002 14:50:57 -0700 (PDT)")
References:  <200209202150.g8KLov9s006373@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Alfred Perlstein <alfred@FreeBSD.org> writes:
>   Log:
>   Fix an infinite loop when _fetch_read() can return 0 (if the
>   connection is broken), take this into account and return at this
>   point.

This probably fixes the wrong bug: _fetch_read() shouldn't return 0.
It currently does if it times out before reading anything (but not, as
you say, if the connection is broken); it should return -1 instead,
and your change to _fetch_getln() should be reverted.

DES
-- 
Dag-Erling Smorgrav - des@ofug.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpy98tw2bz.fsf>