Date: Fri, 21 Apr 2023 17:55:36 +0000 From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 270811] ZFS/PowerPC: Issue after openzfs/zfs@431083f75 import Message-ID: <bug-270811-3630-cx1nEErQd4@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-270811-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-270811-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270811 --- Comment #10 from Mateusz Guzik <mjg@FreeBSD.org> --- /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR zio_checksum_error_impl /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR zio_checksum_error_impl /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR zio_checksum_error_impl /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR zio_checksum_error_impl /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR zio_checksum_error_impl /usr/local/src/base/sys/contrib/openzfs/module/zfs/zio_checksum.c:527 97 SET_ERROR spa_ld_validate_vdevs /usr/local/src/base/sys/contrib/openzfs/module/zfs/spa.c:3582 6 As in: if (!ZIO_CHECKSUM_EQUAL(actual_cksum, expected_cksum)) return (SET_ERROR(ECKSUM)); and finally: if (rvd->vdev_state <=3D VDEV_STATE_CANT_OPEN) { spa_load_failed(spa, "cannot open vdev tree after invalidat= ing " "some vdevs"); vdev_dbgmsg_print_tree(rvd, 2); return (SET_ERROR(ENXIO)); } as all checksum checks failed iow the new checksum routines return a different result than the original. add this on top of the other stuff: diff --git a/sys/contrib/openzfs/module/zfs/zio_checksum.c b/sys/contrib/openzfs/module/zfs/zio_checksum.c index 6090959c5b8c..581c3ccb82e8 100644 --- a/sys/contrib/openzfs/module/zfs/zio_checksum.c +++ b/sys/contrib/openzfs/module/zfs/zio_checksum.c @@ -523,8 +523,12 @@ zio_checksum_error_impl(spa_t *spa, const blkptr_t *bp, info->zbc_has_cksum =3D 1; } - if (!ZIO_CHECKSUM_EQUAL(actual_cksum, expected_cksum)) + if (!ZIO_CHECKSUM_EQUAL(actual_cksum, expected_cksum)) { + printf("bad sum report:\n"); + printf("expected: %lx %lx %lx %lx\n", expected_cksum.zc_word[0], expected_cksum.zc_word[1], expected_cksum.zc_word[2], expected_cksum.zc_word[3]); + printf("actual: %lx %lx %lx %lx\n", actual_cksum.zc_word[0], actual_cksum.zc_word[1], actual_cksum.zc_word[2], actual_cksum.zc_word[3]); return (SET_ERROR(ECKSUM)); + } return (0); } we may need to revert this from upstream: commit 4c5fec01a48acc184614ab8735e6954961990235 Author: Tino Reichardt <milky-zfs@mcmilk.de> Date: Wed Mar 1 09:40:28 2023 +0100 Add generic implementation handling and SHA2 impl --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-270811-3630-cx1nEErQd4>