Date: Tue, 14 Mar 2017 15:28:34 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: Eric van Gyzen <vangyzen@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r315277 - in head/sys: dev/cxgb/ulp/iw_cxgb netinet Message-ID: <CAGHfRMAy9yX0FqPeBJz5OnhVjMxUYUYMJ0HeJm%2BJGf7KfaVUpQ@mail.gmail.com> In-Reply-To: <201703141827.v2EIRmLv080307@repo.freebsd.org> References: <201703141827.v2EIRmLv080307@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 14, 2017 at 11:27 AM, Eric van Gyzen <vangyzen@freebsd.org> wrote: > Author: vangyzen > Date: Tue Mar 14 18:27:48 2017 > New Revision: 315277 > URL: https://svnweb.freebsd.org/changeset/base/315277 > > Log: > KTR: log IPv4 addresses in hex rather than dotted-quad > > When I made the changes in r313821, I fell victim to one of the > classic blunders, the most famous of which is: never get involved > in a land war in Asia. But only slightly less well known is this: > Keep your brain turned on and engaged when making a tedious, sweeping, > mechanical change. KTR can correctly log the immediate integral values > passed to it, as well as constant strings, but not non-constant strings, > since they might change by the time ktrdump retrieves them. Love the Princess Bride reference :). Some might say, bugs like this are, "Inconceivable!" Take care! -Ngie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMAy9yX0FqPeBJz5OnhVjMxUYUYMJ0HeJm%2BJGf7KfaVUpQ>