Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 09 Apr 2001 00:24:51 +0100
From:      Brian Somers <brian@Awfulhak.org>
To:        Dima Dorfman <dima@unixfreak.org>
Cc:        Brian Somers <brian@Awfulhak.org>, mckusick@FreeBSD.org, Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@Awfulhak.org
Subject:   Re: cvs commit: src/bin/ps ps.c 
Message-ID:  <200104082324.f38NOpl11450@hak.lan.Awfulhak.org>
In-Reply-To: Message from Dima Dorfman <dima@unixfreak.org>  of "Sun, 08 Apr 2001 15:48:26 PDT." <20010408224827.EC04A3E09@bazooka.unixfreak.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
> Brian Somers <brian@Awfulhak.org> writes:
> > > So, the question is: do we want a `sess' column?
> > 
> > Personally I preferred it *with* the sess column (my change just 
> > removed an irritating error message - I use ``ps j'' all the time and 
> > have eventually gotten sick of seeing it).  Kirk, do you have any 
> > objections to restoring sess ?
> 
> Well, to [hopefully] make it easier for everyone, I've produced two patches:
> 
> 	http://www.unixfreak.org/~dima/home/ps-sess.diff
> 	http://www.unixfreak.org/~dima/home/ps-tsess.diff
> 
> The first one adds a ki_sess pointer to kinfo_proc.  The second one
> adds ki_sess *and* ki_tsess pointers.  They represent the session
> pointer and the tty session pointer, respectivley.
> 
> Anyone have any objections to these?  If not, anyone feel like
> commiting them?

I Certainly don't.

On a side note, the KINFO_PROC_SIZE looks rather strange.  I assume 
this is there to ensure that sizes stay the same and that it's not 
supposed to work with odd ``long'' sizes ?

I'll test & commit in a couple of days if nobody complains.

> Thanks,
> 
> 					Dima Dorfman
> 					dima@unixfreak.org
 
-- 
Brian <brian@Awfulhak.org>                        <brian@[uk.]FreeBSD.org>
      <http://www.Awfulhak.org>;                   <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200104082324.f38NOpl11450>