Date: Mon, 17 Jul 2017 20:49:15 +0000 From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: [Bug 220785] audio/jack: Add and enable COOKEDMODE option, Use GitHub Message-ID: <bug-220785-12827-fQXH0pgvbo@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-220785-12827@https.bugs.freebsd.org/bugzilla/> References: <bug-220785-12827@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220785 --- Comment #15 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 184450 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=184450 patch > +COOKEDMODE_CFLAGS+= -DOPTION_COOKEDMODE Can you move this one down as well, closer to other option helpers? It only takes effect when both OPTIONS_DEFINE and PORT_OPTIONS (i.e. options selected by user) contain COOKEDMODE. (In reply to Yuri Victorovich from comment #13) > Also, RTCPU isn't the same as DYNSIMD. Looking at the code DYNSIMD seems to use CPUID check to determine which (if any) of SIMD optimizations to use. Not sure how it's different from RTCPU in mplayer, ffmpeg or libvpx. > Changing CFLAGS+= to CFLAGS= strips -O flag from almost all compilation commands. _CFLAGS option helper i.e., COOKEDMODE_CFLAGS in this case. Nothing else is expected to modify it unlike CFLAGS which has -O2 via /usr/share/mk/sys.mk, -fstack-protector via $PORTSDIR/Mk/bsd.ssp.mk, etc. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220785-12827-fQXH0pgvbo>