Date: Tue, 11 Jul 2000 09:04:41 +0100 (BST) From: Doug Rabson <dfr@nlsystems.com> To: Jeroen Ruigrok/Asmodai <asmodai@wxs.nl> Cc: new-bus@freebsd.org Subject: Re: bus_config_intr() Message-ID: <Pine.BSF.4.21.0007110903260.86403-100000@salmon.nlsystems.com> In-Reply-To: <20000710204018.F86887@daemon.ninth-circle.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 10 Jul 2000, Jeroen Ruigrok/Asmodai wrote: > Poul-Henning Kamp was friendly enough to make the following patch: > > http://phk.freebsd.dk/misc/bus_config_intr.patch > > Basically this removes some often duplicated code and wraps it in a > function of itself. I am not quite sure if the name shouldn't be > pcibus_config_intr(), but I welcome arguments, both for and against, > before I commit this to the tree since it makes sense. The if statement "if (res == NULL)" should be "if (*res == NULL)". I have the same reservations as Warner on the use of RF_SHAREABLE. This flag should be passed in probably. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 20 8442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-new-bus" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0007110903260.86403-100000>