Date: Sat, 23 Jan 1999 10:42:00 -0800 (PST) From: John Polstra <jdp@polstra.com> To: eivind@FreeBSD.ORG Cc: committers@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/xlint/xlint xlint.c Message-ID: <199901231842.KAA15954@vashon.polstra.com> In-Reply-To: <199901231507.HAA11453@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <199901231507.HAA11453@freefall.freebsd.org>,
Eivind Eklund <eivind@FreeBSD.ORG> wrote:
> eivind 1999/01/23 07:07:11 PST
>
> Modified files:
> usr.bin/xlint/xlint xlint.c
> Log:
> I may have forgotten to upgrade this value, but that will never happen
> again. (Fully clone the value of __FreeBSD__ from the compiler.)
>
> Revision Changes Path
> 1.6 +8 -6 src/usr.bin/xlint/xlint/xlint.c
I'm glad you put in this automatic solution. But please get
rid of your local STRINGIZE(x) and STRINGIZEINT(x) macros, and
use the FreeBSD-standard __XSTRING(x) instead. It is defined
in <sys/cdefs.h>, which is already available in xlint.c because
<sys/param.h> includes it. (And syle(9) says it's OK to rely on
that.)
Thanks,
John
--
John Polstra jdp@polstra.com
John D. Polstra & Co., Inc. Seattle, Washington USA
"Nobody ever went broke underestimating the taste of the American public."
-- H. L. Mencken
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901231842.KAA15954>